Re: [2/5] WineD3D: Get rid of last_was_foggy_shader friends

2009-01-13 Thread Alexandre Julliard
Stefan Dösinger ste...@codeweavers.com writes:

 This patch breaks a set of fog tests, so they're marked as todo. The tests
 aren't really working correctly right now anyway, they depend on undefined
 default values in opengl. A later patch will make the vertex shader select
 the result.fogcoord(and glsl equivalent) depending on the fog settings, thus
 really fixing this test.

The added todo doesn't fail here:

../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so 
visual.c  touch visual.ok
visual.c:8746: Tests skipped: D3DFMT_G16R16F textures not supported
visual.c:8746: Tests skipped: D3DFMT_G32R32F textures not supported
visual.c:7536: Tests skipped: Card has unconditional pow2 support, skipping 
conditional NP2 tests
visual.c:1540: Test succeeded inside todo block: fog vs1 ps0 fvm0 ftm0 0: got 
color ff00, expected ff00 +-5%(todo)
visual.c:8607: Tests skipped: Only 1 simultaneous render target supported, 
skipping MRT test
make[2]: *** [visual.ok] Error 1

-- 
Alexandre Julliard
julli...@winehq.org




RE: [2/5] WineD3D: Get rid of last_was_foggy_shader friends

2009-01-13 Thread Stefan Dösinger
 visual.c:1540: Test succeeded inside todo block: fog vs1 ps0 fvm0 ftm0
 0: got color ff00, expected ff00 +-5%(todo)
I thought I added an exception for this case, where the wrong calculation gets 
lucky and produces the right result. Well, I'll double-check