Re: [2/7] urlmon/tests: Removed no longer needed todo_wine's

[Paul Vriens]

On 09/09/2010 02:46 AM, Thomas Mullaly wrote:

These todo's should have been removed as I implemented each of the
IUriBuilder_{Get/Set}* functions, but, I forgot about them.


Hi Thomas,

todo_wine's that succeed are marked as failures so that means these are 
not fixed on (at least) AJ's box as otherwise previous patches would 
have been rejected.


Judging by the test.winehq.org results there are only todo_wine's and no 
failures on Wine.


--
Cheers,

Paul.

Re: [2/7] urlmon/tests: Removed no longer needed todo_wine's

[Thomas Mullaly]

Hi Paul,

On Thu, Sep 9, 2010 at 2:19 AM, Paul Vriens paul.vriens.w...@gmail.comwrote:

 todo_wine's that succeed are marked as failures so that means these are not
 fixed on (at least) AJ's box as otherwise previous patches would have been
 rejected.


The reason they didn't show up as test succeeded failures on wine is because
they weren't getting executed on wine. This is because IUriBuilder_GetIUri
wasn't implemented which means it would skip those tests on wine. I
implemented GetIUri in patch 5/7 of this set which would have caused a lot
of test succeeded failures until the todo's were removed. So I decided
(since removing the todo's just by themselves resulted in a lot of changes)
to keep this patch separate from the 5/7 patch. Of course, if it's
preferred, I can always merge the changes into patch 5/7 and resubmit this
set.

-- 
Thomas Mullaly
thomas.mull...@gmail.com