Re: [7/10] winemenubuilder: Create a basic Info.plist.

2013-03-20 Thread Per Johansson 
On Tue, Mar 19, 2013 at 5:57 AM, Ken Thomases  wrote:
> On Mar 17, 2013, at 12:18 PM, Per Johansson wrote:
>
>> +namestr = CFStringCreateWithCString(NULL, link_name, 
>> CFStringGetSystemEncoding());
>
> You should use CFStringCreateWithFileSystemRepresentation() to create 
> CFStrings from POSIX path strings.

Fixed.

Thanks,
-- 
Per Johansson

Re: [7/10] winemenubuilder: Create a basic Info.plist.

2013-03-18 Thread Ken Thomases 
On Mar 17, 2013, at 12:18 PM, Per Johansson wrote:

> +namestr = CFStringCreateWithCString(NULL, link_name, 
> CFStringGetSystemEncoding());

You should use CFStringCreateWithFileSystemRepresentation() to create CFStrings 
from POSIX path strings.


> +pathstr = CFStringCreateWithCString(NULL, path, 
> CFStringGetSystemEncoding());

Same thing here.


> +data = CFPropertyListCreateData(NULL, propertyList, format, 0, &err);

Since you don't use "err", just pass NULL.

-Ken