On Monday 26 June 2006 6:06 pm, Jonathan Ernst wrote:
> Le lundi 26 juin 2006 à 15:33 -0400, Chris Morgan a écrit :
> [...]
>
> > Comments? Questions?
>
> Index: index.php
> ===
> RCS file: /opt/cvs-commit/appdb/index.php,v
> retrieving revision 1.33
> diff -u -r1.33 index.php
> --- index.php 21 Jun 2006 01:04:12 - 1.33
> +++ index.php 26 Jun 2006 19:26:39 -
> @@ -7,7 +7,7 @@
> * application environment
> */
> include("path.php");
> -require(BASE."include/incl.php");
> +require_once(BASE."include/incl.php");
>
> Why use require_once ? It is slower and is bad unless you intend to
> include index.php in another file where incl.php is also included...
>
I can't recall why anymore. I've reverted this change and everything still
seems to work.
>
> Index: include/image.php
> ===
> RCS file: /opt/cvs-commit/appdb/include/image.php,v
> retrieving revision 1.5
> diff -u -r1.5 image.php
> --- include/image.php 21 Sep 2005 14:16:40 - 1.5
> +++ include/image.php 26 Jun 2006 19:26:40 -
> @@ -3,6 +3,8 @@
> /* image and image_resource classes */
> /*/
>
> +include_once(BASE."include/incl.php");
> +
>
> This time you use include once, we should use require everywhere if
> incl.php is required (and including a file in another include is not so
> pretty IMHO).
>
Reverted this change too since I can't recall why I made this change either.
>
>
> +/* NOTE: we can't update the users password like we can update
> other */
> +/* fields such as their email or username because the password is
> hashed */
> +/* in the database so we can't keep the users password in a class
> member variable */
> +/* and use update() because we can't check if the password changed
> without hashing */
> +/* the newly supplied one */
> +function update_password($sPassword)
>
>
> Should updatePassword according to our coding standards (method names).
Updated.
Chris
