Re: [PATCH] cmd: removed %CD% test.

2010-03-17 Thread Jacek Caban

On 3/16/10 5:42 PM, Yann Droneaud wrote:

Le mardi 16 mars 2010 à 11:25 -0500, Austin English a écrit :
   

On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaudy...@droneaud.fr  wrote:
 

%CD% seems not supported on Windows NT 4.

The patch which introduce this test was based on MSDN documentation
and only tested on Windows XP
   

Instead of removing it, perhaps the cmd test framework needs to
understand the broken() macro...

 

As %CD% was added in a batch file (test_builtins.cmd) so it's easier to
remove it.
   


Not really, I've sent a patch:
http://source.winehq.org/patches/data/59373

Jacek




Re: [PATCH] cmd: removed %CD% test.

2010-03-16 Thread Paul Vriens

On 03/16/2010 10:53 AM, Yann Droneaud wrote:

%CD% seems not supported on Windows NT 4.

The patch which introduce this test was based on MSDN documentation
and only tested on Windows XP


Hi Yann,

Winetestbot (https://winetestbot.geldorp.nl/index.pl) provides you with 
several Windows flavors for testing purposes.


--
Cheers,

Paul.




Re: [PATCH] cmd: removed %CD% test.

2010-03-16 Thread Austin English
On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud y...@droneaud.fr wrote:
 %CD% seems not supported on Windows NT 4.

 The patch which introduce this test was based on MSDN documentation
 and only tested on Windows XP

Instead of removing it, perhaps the cmd test framework needs to
understand the broken() macro...

-- 
-Austin




Re: [PATCH] cmd: removed %CD% test.

2010-03-16 Thread Yann Droneaud
Le mardi 16 mars 2010 à 11:25 -0500, Austin English a écrit :
 On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud y...@droneaud.fr wrote:
  %CD% seems not supported on Windows NT 4.
 
  The patch which introduce this test was based on MSDN documentation
  and only tested on Windows XP
 
 Instead of removing it, perhaps the cmd test framework needs to
 understand the broken() macro...
 

As %CD% was added in a batch file (test_builtins.cmd) so it's easier to
remove it.

We can probably split test_builtins.cmd in smaller chunks, then use
those macro and then use todo(), broken(), etc.

They're some patches on test_builtins.cmd waiting, so I'm not gonna do
this first.

-- 
Yann Droneaud