Re: [PATCH] shell32: IShellDispatch_NameSpace: Special-folder argument shouldn't be negative.

2011-11-03 Thread Octavian Voicu 
On Thu, Nov 3, 2011 at 8:00 PM, Christian Inci
 wrote:
> But my C is a bit rusty, so I don't know a clean way to enumerating an enum.

You cannot enumerate an enum. An enum is just a way to define a bunch
of related constants. If you don't set explicit values, they will get
consecutive values (first one being 0); otherwise, the range for the
constants might not be sequential.

You can use a for loop starting from first enum value to last enum
value, or you can put all the enum values in an array and loop over
the array.

Octavian

Re: [PATCH] shell32: IShellDispatch_NameSpace: Special-folder argument shouldn't be negative.

2011-11-03 Thread Christian Inci 

Hello,

I've tested it now with a value of 0x75 (hex) and it fails.

But my C is a bit rusty, so I don't know a clean way to enumerating an enum.


Greetings,
Christian


On 11/03/2011 02:35 PM, Alexander Morozov wrote:

  -1 in this test is only a sample of a bad constant. Do you sure
  that S_OK should be returned for any positive argument?

Re: [PATCH] shell32: IShellDispatch_NameSpace: Special-folder argument shouldn't be negative.

2011-11-03 Thread Alexander Morozov 

-1 in this test is only a sample of a bad constant. Do you sure
that S_OK should be returned for any positive argument?