Re: [PATCH 04/10] wined3d: Add ENTER_GL/LEAVE_GL in IWineD3DSurfaceImpl_Release.

2008-04-03 Thread Alexander Dorofeyev
Hi.

Sounds like a good idea. Unfortunately, it's too late to rework that patch as 
it 
seems to be in git by now. I suggest you send this improvement as a patch under 
your name.

Allan Tong wrote:
> Perhaps the call to ActivateContext should be moved outside of the if
> block since there are other gl calls in the function.  Then you could
> move the glDeleteRenderbuffers block before the gdi section and
> combine the ENTER_GL/LEAVE_GL blocks into one.
> 
>  - Allan




Re: [PATCH 04/10] wined3d: Add ENTER_GL/LEAVE_GL in IWineD3DSurfaceImpl_Release.

2008-04-02 Thread Allan Tong
Perhaps the call to ActivateContext should be moved outside of the if
block since there are other gl calls in the function.  Then you could
move the glDeleteRenderbuffers block before the gdi section and
combine the ENTER_GL/LEAVE_GL blocks into one.

 - Allan