Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Sven Baars

Joel Holdsworth wrote:



> Hi Joel,
>
> I think this has been mentioned before, but the monitor icons (32-bit
> and 8-bit for size 32) show a wider lower half of the monitor compared
> to the upper half (I think the 32-bit size 22 as well).
> 

 

I've heard feedback about the screen colour before, which I've 
resolved. Never any queries about the shape of the screen. The reason 
it's slightly wider at the top to the bottom is that it is drawn in 
perspective, which is how the screen is drawn in the Tango base set. I 
believe only The 48px-32bit and 48px-8bit have this.





  

Especially the 8-bit version does look a bit weird though.

Oh, and while you're at it: the certerror.bmp and smallicons.bmp still 
use the no entrance sign instead of the cross from oic_hand.ico. IIRC 
people found this confusing or something.





Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Paul Vriens

On 04/14/2010 02:04 PM, Joel Holdsworth wrote:




 > Hi Joel,
 >
 > I think this has been mentioned before, but the monitor icons (32-bit
 > and 8-bit for size 32) show a wider lower half of the monitor compared
 > to the upper half (I think the 32-bit size 22 as well).
 >

I've heard feedback about the screen colour before, which I've resolved.
Never any queries about the shape of the screen. The reason it's


I digged a bit and found:

http://www.winehq.org/pipermail/wine-devel/2009-November/079938.html


slightly wider at the top to the bottom is that it is drawn in
perspective, which is how the screen is drawn in the Tango base set. I
believe only The 48px-32bit and 48px-8bit have this.


I let others judge whether this is ok, it's just something I noticed.

--
Cheers,

Paul.




Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Joel Holdsworth



> Hi Joel,
>
> I think this has been mentioned before, but the monitor icons (32-bit
> and 8-bit for size 32) show a wider lower half of the monitor compared
> to the upper half (I think the 32-bit size 22 as well).
>  
I've heard feedback about the screen colour before, which I've resolved. Never
any queries about the shape of the screen. The reason it's slightly wider at the
top to the bottom is that it is drawn in perspective, which is how the screen is
drawn in the Tango base set. I believe only The 48px-32bit and 48px-8bit have
this.


Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Paul Vriens

On 04/14/2010 01:41 PM, Paul Vriens wrote:

On 04/13/2010 10:59 PM, Joel Holdsworth wrote:

Signed-off-by: Joel Holdsworth
---
dlls/shell32/mycomputer.ico | Bin 15086 -> 25214 bytes
dlls/shell32/mycomputer.svg | 2400
++-
2 files changed, 1477 insertions(+), 923 deletions(-)







Hi Joel,

I think this has been mentioned before, but the monitor icons (32-bit
and 8-bit for size 32) show a wider lower half of the monitor compared


sorry that should have been size 48x48


to the upper half (I think the 32-bit size 22 as well).


and size 32x32.

--
Cheers,

Paul.




Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Paul Vriens

On 04/13/2010 10:59 PM, Joel Holdsworth wrote:

Signed-off-by: Joel Holdsworth
---
  dlls/shell32/mycomputer.ico |  Bin 15086 ->  25214 bytes
  dlls/shell32/mycomputer.svg | 2400 ++-
  2 files changed, 1477 insertions(+), 923 deletions(-)







Hi Joel,

I think this has been mentioned before, but the monitor icons (32-bit 
and 8-bit for size 32) show a wider lower half of the monitor compared 
to the upper half (I think the 32-bit size 22 as well).


--
Cheers,

Paul.