Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.

2009-08-24 Thread Alexandre Julliard 
Huw Davies  writes:

> On Mon, Aug 24, 2009 at 01:51:24PM +0200, Alexandre Julliard wrote:
>> Huw Davies  writes:
>> 
>> > diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in
>> > index d6f71a0..cebf659 100644
>> > --- a/dlls/msdaps/Makefile.in
>> > +++ b/dlls/msdaps/Makefile.in
>> > @@ -5,6 +5,7 @@ VPATH = @srcdir@
>> >  MODULE= msdaps.dll
>> >  IMPORTS   = oleaut32 rpcrt4 kernel32 ntdll
>> >  EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0x06210e88, 0x01f5, 
>> > 0x11d1, { 0xb5, 0x12, 0x00, 0x80, 0xc7, 0x81, 0xc3, 0x84 } }"
>> > +EXTRAIDLFLAGS = -a2
>> 
>> Won't this break the 64-bit build?
>
> Yes, good point.  64-bit should be left to default to 8 byte
> alignment.  How do I do that?

I suppose the easiest is to extend the -a option to allow specifying two
alignment sizes, or to add explicit options like --win32-align/--win64-align.

-- 
Alexandre Julliard
julli...@winehq.org

Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.

2009-08-24 Thread Huw Davies 
On Mon, Aug 24, 2009 at 01:51:24PM +0200, Alexandre Julliard wrote:
> Huw Davies  writes:
> 
> > diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in
> > index d6f71a0..cebf659 100644
> > --- a/dlls/msdaps/Makefile.in
> > +++ b/dlls/msdaps/Makefile.in
> > @@ -5,6 +5,7 @@ VPATH = @srcdir@
> >  MODULE= msdaps.dll
> >  IMPORTS   = oleaut32 rpcrt4 kernel32 ntdll
> >  EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0x06210e88, 0x01f5, 
> > 0x11d1, { 0xb5, 0x12, 0x00, 0x80, 0xc7, 0x81, 0xc3, 0x84 } }"
> > +EXTRAIDLFLAGS = -a2
> 
> Won't this break the 64-bit build?

Yes, good point.  64-bit should be left to default to 8 byte
alignment.  How do I do that?

Huw.

Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.

2009-08-24 Thread Alexandre Julliard 
Huw Davies  writes:

> diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in
> index d6f71a0..cebf659 100644
> --- a/dlls/msdaps/Makefile.in
> +++ b/dlls/msdaps/Makefile.in
> @@ -5,6 +5,7 @@ VPATH = @srcdir@
>  MODULE= msdaps.dll
>  IMPORTS   = oleaut32 rpcrt4 kernel32 ntdll
>  EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0x06210e88, 0x01f5, 
> 0x11d1, { 0xb5, 0x12, 0x00, 0x80, 0xc7, 0x81, 0xc3, 0x84 } }"
> +EXTRAIDLFLAGS = -a2

Won't this break the 64-bit build?

-- 
Alexandre Julliard
julli...@winehq.org