Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On 24 June 2010 05:18, Misha Koshelev misha680 at gmail.com wrote: Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like git shortlog -s -n if the advice you're getting is actually worth taking. The way I see it, you have more experience with getting patches accepted yourself. More to the point, if you look at http://source.winehq.org/patches/, you'll see 62909 is marked as Deferred, so resending in a slightly different form isn't going to help much. As for the patch itself, I'm not convinced there's value in having a separate file for Shape Drawing Functions, these are clearly mesh constructors. I thought the original patch was mostly ok in that regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *. Oh and the LPDIRECT3DDEVICE9's are straight from line.c tests. But I will heed your advice on the %d's Misha
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On 25 June 2010 18:20, Misha Koshelev misha...@gmail.com wrote: regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *. Oh and the LPDIRECT3DDEVICE9's are straight from line.c tests. But I will heed your advice on the %d's I wouldn't object to a patch based on either of those alone, but if you'll have to resend anyway I might as well point those out.
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On Fri, 2010-06-25 at 18:59 +0200, Henri Verbeet wrote: On 25 June 2010 18:20, Misha Koshelev misha...@gmail.com wrote: regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *. Oh and the LPDIRECT3DDEVICE9's are straight from line.c tests. But I will heed your advice on the %d's I wouldn't object to a patch based on either of those alone, but if you'll have to resend anyway I might as well point those out. Very well then. Let's just leave the deferred patch as is if that's okay http://source.winehq.org/patches/data/62909 and I'll send out further patches post-code freeze heeding all of your advice. Thank you Misha
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On 24 June 2010 05:18, Misha Koshelev misha...@gmail.com wrote: Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like git shortlog -s -n if the advice you're getting is actually worth taking. The way I see it, you have more experience with getting patches accepted yourself. More to the point, if you look at http://source.winehq.org/patches/, you'll see 62909 is marked as Deferred, so resending in a slightly different form isn't going to help much. As for the patch itself, I'm not convinced there's value in having a separate file for Shape Drawing Functions, these are clearly mesh constructors. I thought the original patch was mostly ok in that regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *.
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On 24 June 2010 05:18, Misha Koshelev misha680 at gmail.com wrote: Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like git shortlog -s -n if the advice you're getting is actually worth taking. The way I see it, you have more experience with getting patches accepted yourself. More to the point, if you look at http://source.winehq.org/patches/, you'll see 62909 is marked as Deferred, so resending in a slightly different form isn't going to help much. Ah I see thank you. I take it this means deferred until post-code freeze (please correct me if incorrect). As for the patch itself, I'm not convinced there's value in having a separate file for Shape Drawing Functions, these are clearly mesh constructors. I thought the original patch was mostly ok in that regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *. Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone bugs for now and see if I can help. Post code freeze, I can then start on the d3dx9 stuff as I am really not akin to having my own private repo as of yet and I think that going from a private repo to getting patches into Wine itself might be a little more difficult than I'd like - rather than doing it all at once... So thus for now work on 1.2 milestones. Then D3DX9. Off to work... Misha
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On 24 June 2010 18:11, Misha Koshelev misha...@gmail.com wrote: http://source.winehq.org/patches/, you'll see 62909 is marked as Deferred, so resending in a slightly different form isn't going to help much. Ah I see thank you. I take it this means deferred until post-code freeze (please correct me if incorrect). Pretty much. (There's a legend with more verbose explanations at the bottom of that page.) Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone bugs for now and see if I can help. Yeah, milestone bugs should generally be ok, as well as any open regressions.
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
Henri Verbeet hverb...@gmail.com wrote: On 24 June 2010 18:11, Misha Koshelev misha...@gmail.com wrote: Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone bugs for now and see if I can help. Yeah, milestone bugs should generally be ok, as well as any open regressions. Some of the regression bugs are pre-Wine 1.0. Sad, but if you can fix those, it would greatly help bring Wine code up-to-date. James McKenzie
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
On Thu, 2010-06-24 at 11:33 -0700, James Mckenzie wrote: Henri Verbeet hverb...@gmail.com wrote: On 24 June 2010 18:11, Misha Koshelev misha...@gmail.com wrote: Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone bugs for now and see if I can help. Yeah, milestone bugs should generally be ok, as well as any open regressions. Some of the regression bugs are pre-Wine 1.0. Sad, but if you can fix those, it would greatly help bring Wine code up-to-date. James McKenzie Thanks James. Right now I am looking at: http://bugs.winehq.org/show_bug.cgi?id=13891 but at some point willing to track down regressions too. If you have a link would be great (I am leaving to Russia on Sat so I'm not sure how much I'll be able to get done before then though). Misha
Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2885 Your paranoid android. === WINEBUILD (build) === Make failed
