Re: [PATCH 2/2] d3dx9/line: Implemented tests for ID3DXLine's Begin and End methods.
2011/6/18 Charles Welton : > --- > dlls/d3dx9_36/tests/line.c | 23 +++ > 1 files changed, 23 insertions(+), 0 deletions(-) > > +srand(time(NULL)); > +random = ((FLOAT) rand())/RAND_MAX; /* Random value between 0.0 and 1.0. > We're using this later. */ I didn't check why your patch failed with the testbot. Nevertheless, you should avoid to use random values: the tests should be repeatable. Just pick some arbitrary values and use them. Also, for better clarity, you may want to use a different variable for the modified identity matrix (because, at that point, it isn't identity anymore). Maybe you could check the world matrix between ID3DXLine_Begin and ID3DXLine_End too.
Re: [PATCH 2/2] d3dx9/line: Implemented tests for ID3DXLine's Begin and End methods.
Can't reproduce as this seem to only work with wine64. Perhaps there's some issue with the headers? Code compiles fine under wine32. On 06/18/2011 11:50 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=11808 > > Your paranoid android. > > > === WINEBUILD (build) === > Make failed -- Charles Welton
Re: [PATCH 2/2] d3dx9/line: Implemented tests for ID3DXLine's Begin and End methods.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11808 Your paranoid android. === WINEBUILD (build) === Make failed
