Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 6)

2013-09-13 Thread Jactry Zeng 
Hi Nikolay,
2013/9/13 Nikolay Sivov 
>
> On 9/13/2013 15:05, Jactry Zeng wrote:
>>
>>   bUnicode = !bRtf && pStruct->codepage == CP_UNICODE;
>> +bUTF8 = (lParam && (!strncmp((char *)lParam, utf8_bom, 3)));
>
> What will happen if both of these are true? This needs a test with BOM
and 'codepage' set to 1200.

Thanks for your review.
The test showed that bUnicode have a higher priority that BOM.
I will try it again.


--
Regards,
Jactry Zeng

Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 6)

2013-09-13 Thread Nikolay Sivov 

On 9/13/2013 15:05, Jactry Zeng wrote:

  bUnicode = !bRtf && pStruct->codepage == CP_UNICODE;
+bUTF8 = (lParam && (!strncmp((char *)lParam, utf8_bom, 3)));
What will happen if both of these are true? This needs a test with BOM 
and 'codepage' set to 1200.