Re: [PATCH 3/4] msi: automation: Generalize list implementation.
Misha Koshelev [EMAIL PROTECTED] writes: if (wFlags DISPATCH_PROPERTYGET) { V_VT(pVarResult) = VT_I4; -V_I4(pVarResult) = data-iCount; +V_I4(pVarResult) = data-ulCount; I committed this patch, but I can't resist pointing out that if you had simply named the field count instead of using the (idiotic) Hungarian notation, the code would be just as clear, and you wouldn't need to rename it everywhere when making it unsigned... -- Alexandre Julliard [EMAIL PROTECTED]
Re: [PATCH 3/4] msi: automation: Generalize list implementation.
On Fri, 2007-05-18 at 20:15 +0200, Alexandre Julliard wrote: Misha Koshelev [EMAIL PROTECTED] writes: if (wFlags DISPATCH_PROPERTYGET) { V_VT(pVarResult) = VT_I4; -V_I4(pVarResult) = data-iCount; +V_I4(pVarResult) = data-ulCount; I committed this patch, but I can't resist pointing out that if you had simply named the field count instead of using the (idiotic) Hungarian notation, the code would be just as clear, and you wouldn't need to rename it everywhere when making it unsigned... So is the general recommendation for wine that we not use Hungarian notation then? Misha
Re: [PATCH 3/4] msi: automation: Generalize list implementation.
Am Freitag 18 Mai 2007 23:17 schrieb Misha Koshelev: On Fri, 2007-05-18 at 20:15 +0200, Alexandre Julliard wrote: Misha Koshelev [EMAIL PROTECTED] writes: if (wFlags DISPATCH_PROPERTYGET) { V_VT(pVarResult) = VT_I4; -V_I4(pVarResult) = data-iCount; +V_I4(pVarResult) = data-ulCount; I committed this patch, but I can't resist pointing out that if you had simply named the field count instead of using the (idiotic) Hungarian notation, the code would be just as clear, and you wouldn't need to rename it everywhere when making it unsigned... So is the general recommendation for wine that we not use Hungarian notation then? Alexandre usually calls it Hungarian Line Noise, I guess that means no.
Re: [PATCH 3/4] msi: automation: Generalize list implementation.
Misha Koshelev wrote: So is the general recommendation for wine that we not use Hungarian notation then? Misha IMHO, a prefix is of little value if it merely echos the declared type of the variable it represents, especially in a small-scope situation. To be of value, a prefix needs to convey other information, such as implying the purpose of the variable, or acting as a grouping element for a set of related variables. -- Andy.