Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

2011-11-07 Thread Alexandre Julliard
Eric Pouech  writes:

> do you consider it's the same for winepath and winetest (number 5& 6
> in patchset) ? or shall I resubmit the remaining two ?

It's the same for winepath, yes. winetest is probably OK to change.

-- 
Alexandre Julliard
julli...@winehq.org




Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

2011-11-07 Thread Eric Pouech

Le 07/11/2011 14:12, Alexandre Julliard a écrit :

Eric Pouech  writes:


#28185

A+
---

  programs/uninstaller/main.c |   65 ++-
  1 files changed, 46 insertions(+), 19 deletions(-)

I'm not sure that's a good idea. The output of uninstaller is meant to
be used by Unix apps, it's not something a user would want to display on
the console.

do you consider it's the same for winepath and winetest (number 5& 6 in 
patchset) ? or shall I resubmit the remaining two ?

A+

--
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the 
ingenuity of a complete idiot." (Douglas Adams)





Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

2011-11-07 Thread Alexandre Julliard
Eric Pouech  writes:

> #28185
>
> A+
> ---
>
>  programs/uninstaller/main.c |   65 
> ++-
>  1 files changed, 46 insertions(+), 19 deletions(-)

I'm not sure that's a good idea. The output of uninstaller is meant to
be used by Unix apps, it's not something a user would want to display on
the console.

-- 
Alexandre Julliard
julli...@winehq.org