Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.

[Yann Droneaud]

Le mercredi 17 mars 2010 à 14:31 +0100, paul.vriens.winea a écrit :
> On 03/17/2010 02:22 PM, Jacek Caban wrote:
> > --- a/programs/cmd/tests/test_builtins.cmd.exp
> > +++ b/programs/cmd/tests/test_builtins.cmd.exp
> > @@ -16,6 +16,7 @@ bar
> >   ~dp0 should be directory containing batch file
> >   @p...@\
> >   @p...@\
> > + at pwd@@or_broken at ECHO is off.
> 
> Won't this fail on non English locales? In this case it will only fail
> on non English NT4 boxes, but still.
> 

As stated in a reply to my first patch,
http://www.winehq.org/pipermail/wine-devel/2010-March/082234.html

The output of echo without any parameters is localized, so it was
difficult to test unknown / empty variable alone. As a workaround I've
added some prefix, suffix to the pattern.

Regards.

-- 
Yann Droneaud

Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.

[Paul Vriens]

On 03/17/2010 02:22 PM, Jacek Caban wrote:

--- a/programs/cmd/tests/test_builtins.cmd.exp
+++ b/programs/cmd/tests/test_builtins.cmd.exp
@@ -16,6 +16,7 @@ bar
  ~dp0 should be directory containing batch file
  @p...@\
  @p...@\
+...@pwd@@or_bro...@echo is off.


Won't this fail on non English locales? In this case it will only fail 
on non English NT4 boxes, but still.


--
Cheers,

Paul.