Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype (2nd attempt)

2006-09-28 Thread Vitaliy Margolen 
Thomas Weidenmueller wrote:
 The parameter of RpcMgmtSetServerStackSize needs to be unsigned long,
 not unsigned int.
 
 - Thomas
 
It's been discussed numerous times, you should avoid use of 'long' in
Wine. On win64 sizeof(long) == 4. On Linux64 sizeof(long) == 8.

Vitaliy.

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype (2nd attempt)

2006-09-28 Thread Vitaliy Margolen 
Vitaliy Margolen wrote:
 Thomas Weidenmueller wrote:
 The parameter of RpcMgmtSetServerStackSize needs to be unsigned long,
 not unsigned int.

 - Thomas

 It's been discussed numerous times, you should avoid use of 'long' in
 Wine. On win64 sizeof(long) == 4. On Linux64 sizeof(long) == 8.
 
I will answer myself: it is declared as 'unsigned long' in SDK.

Sorry for the noise.

Vitaliy

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Paul Vriens 
On Wed, 2006-09-27 at 14:40 +0200, Thomas Weidenmueller wrote:
FIXME((0x%x): stub\n, ThreadStackSize);

Shouldn't that be (0x%lx) then ?

Cheers,

Paul.

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Dmitry Timoshkov 

Thomas Weidenmueller [EMAIL PROTECTED] wrote:


The parameter of RpcMgmtSetServerStackSize needs to be unsigned long,
not unsigned int.


Then it should be changed to 'ULONG' or 'unsigned LONG' for compatibility
with Win64.

--
Dmitry.

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Michael Stefaniuc 
Thomas Weidenmueller wrote:
 The parameter of RpcMgmtSetServerStackSize needs to be unsigned long,
 not unsigned int.
Won't work on Win64. long is 32bits on Win32 and Win64. On Linux64 long
is 64bits.

bye
michael

 
 
 Index: dlls/rpcrt4/rpc_server.c
 ===
 RCS file: /home/wine/wine/dlls/rpcrt4/rpc_server.c,v
 retrieving revision 1.58
 diff -u -r1.58 rpc_server.c
 --- dlls/rpcrt4/rpc_server.c  30 Jun 2006 19:16:38 -  1.58
 +++ dlls/rpcrt4/rpc_server.c  27 Sep 2006 12:38:00 -
 @@ -1008,7 +1008,7 @@
  /***
   * RpcMgmtSetServerStackSize (RPCRT4.@)
   */
 -RPC_STATUS WINAPI RpcMgmtSetServerStackSize(unsigned int ThreadStackSize)
 +RPC_STATUS WINAPI RpcMgmtSetServerStackSize(unsigned long ThreadStackSize)
  {
FIXME((0x%x): stub\n, ThreadStackSize);
return RPC_S_OK;


-- 
Michael Stefaniuc   Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Thomas Weidenmueller 
Dmitry Timoshkov wrote:
 Then it should be changed to 'ULONG' or 'unsigned LONG' for compatibility
 with Win64.
It's also defined as unsigned long in the PSDK headers, not
ULONG/unsigned LONG.

- Thomas

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Dmitry Timoshkov 

Thomas Weidenmueller [EMAIL PROTECTED] wrote:


It's also defined as unsigned long in the PSDK headers, not
ULONG/unsigned LONG.


The problem is that 'long' is 32-bit in Win64 while in 64-bit Linux
it's 64-bit.

--
Dmitry.