Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

[Saulius Krasuckas]

* On Thu, 30 Jun 2005, Paul Vriens wrote:
> 
> > Saulius Krasuckas <[EMAIL PROTECTED]>
> > - Break from the loop to restore SM_SWAPBUTTON metrics.
  ...
> > --- dlls/user/tests/sysparams.c 20 Jun 2005 15:36:17 -  1.38
> > +++ dlls/user/tests/sysparams.c 30 Jun 2005 07:36:40 -
> > @@ -1011,7 +1011,7 @@ static void test_SPI_SETMOUSEBUTTONSWAP(
> >  rc=SystemParametersInfoA( SPI_SETMOUSEBUTTONSWAP, vals[i], 0,
> >SPIF_UPDATEINIFILE | SPIF_SENDCHANGE );
> >  if (!test_error_msg(rc!=vals[i],"SPI_{GET,SET}MOUSEBUTTONSWAP"))
> > -return;
> > +break;
> 
> It's nice to break but the the end-result will be that the test fails on 
> all windows versions I could my hands on 

Test fails because of flawed logic at if-statement, which I have no time 
to debug for.  So I chose to have flawed check instead of having 
mouse-buttons swapped (which isn't so visible from the test results).

> and that the previous setting is restored. Not very useful it seams.

So if the buttons were standard mapped, then they got swapped during test 
and then test failed, you think it is OK to leave buttons swapped?

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

[jakov]

> Saulius Krasuckas wrote:
>>>ChangeLog: Fix bug that left mouse buttons swapped after tests
>>>
>>>Ivan.
>>
>>
>> I think your patch causes test to fail on Wine, Ivan.  My try goes next.
>
> Maybe that isn't a bad thing, the results from the latest build of
> winetest shows this test fails
> on windows 2000, windows nt, windows me, and windows 98se, so I somewhat
> doubt the wine behaviour is
> correct.
>
> Ivan.

And this is exactly why no part of winetest should be allowed to fail.

//Jakob

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

[Ivan Leo Puoti]

Saulius Krasuckas wrote:

ChangeLog: Fix bug that left mouse buttons swapped after tests

Ivan.



I think your patch causes test to fail on Wine, Ivan.  My try goes next.


Maybe that isn't a bad thing, the results from the latest build of winetest 
shows this test fails
on windows 2000, windows nt, windows me, and windows 98se, so I somewhat doubt the wine behaviour is 
correct.


Ivan.

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

[Paul Vriens]

>> ChangeLog: Fix bug that left mouse buttons swapped after tests
>>
>> Ivan.
>
> I think your patch causes test to fail on Wine, Ivan.  My try goes next.
>
>
> ChangeLog:
>   Saulius Krasuckas <[EMAIL PROTECTED]>
>   - Break from the loop to restore SM_SWAPBUTTON metrics.
>   - SetLastError() to see if restoration changes it.
>
>
> Index: dlls/user/tests/sysparams.c
> ===
> RCS file: /home/wine/wine/dlls/user/tests/sysparams.c,v
> retrieving revision 1.38
> diff -p -u -r1.38 sysparams.c
> --- dlls/user/tests/sysparams.c 20 Jun 2005 15:36:17 -  1.38
> +++ dlls/user/tests/sysparams.c 30 Jun 2005 07:36:40 -
> @@ -1011,7 +1011,7 @@ static void test_SPI_SETMOUSEBUTTONSWAP(
>  rc=SystemParametersInfoA( SPI_SETMOUSEBUTTONSWAP, vals[i], 0,
>SPIF_UPDATEINIFILE | SPIF_SENDCHANGE );
>  if (!test_error_msg(rc!=vals[i],"SPI_{GET,SET}MOUSEBUTTONSWAP"))
> -return;
> +break;
It's nice to break but the the end-result will be that the test fails on
all windows versions I could my hands on and that the previous setting is
restored. Not very useful it seams.

Cheers,

Paul.