Re: Alex Villacís Lasso : uxtheme: Speed up UXTHEME_SizedBlt in the ST_T ILE by building an appropriately-sized me mory bitmap out of the tile instead of iterating with UXTHEME_Blt () directly

[Frank Richter]

On 23.04.2008 01:00, Alex Villací­s Lasso wrote:
 Have you seen a theme that uses  alpha and breaks with my patch?

It's more of a dim recollection from the time I worked on the theming 
stuff. Mind you, it's a while back now, so assuming I remember right the 
underlying issue might have been fixed already.

-f.r.

Re: Alex Villacís Lasso : uxtheme: Speed up UXTHEME_SizedBlt in the ST_T ILE by building an appropriately-sized me mory bitmap out of the tile instead of iterating with UXTHEME_Blt () directly

[Alex Villací­s Lasso]

Frank Richter escribio':
 On 22.04.2008 13:47, Alexandre Julliard wrote:
   
 uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an 
 appropriately-sized memory bitmap out of the tile instead of iterating with 
 UXTHEME_Blt() directly.
 

 But does that keep the alpha channel intact?

 -f.r.

   
I directed my themes to the ones on the WinXP partition, and saw no 
difference after the patch, other than the increase in speed. However, 
this might not be a proper test case. I used CreateCompatibleDC out of 
the source HDC, and CreateCompatibleBitmap in the same way. If these 
operations preserve the alpha channel, and BitBlt(SRCCOPY) does too, the 
patch as a whole should be correct. Have you seen a theme that uses 
alpha and breaks with my patch?

-- 
perl -e '$x=2.4;print sprintf(%.0f + %.0f = %.0f\n,$x,$x,$x+$x);'