Re: Fix for metafile test
Dan Kegel [EMAIL PROTECTED] wrote: Here's what I get when I run 'make test' on Wine: [skipped] metafile.c:91: Test failed: pass 0: dx[42] (1081735508) didn't match 4 make[3]: *** [metafile.ok] Error 43 Is the metafile test supposed to be broken like this under Wine? That's because you have no truetype fonts installed. X11 fonts are broken in that respect. -- Dmitry.
Re: Fix for metafile test
Dmitry Timoshkov wrote: metafile.c:91: Test failed: pass 0: dx[42] (1081735508) didn't match 4 make[3]: *** [metafile.ok] Error 43 Is the metafile test supposed to be broken like this under Wine? That's because you have no truetype fonts installed. X11 fonts are broken in that respect. Thanks for the explanation. It would be nice if the test would explain that. Lots of people don't have truetype fonts, and the test should xfail with the message I don't have what I need to run rather than fail with wine is broken. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html
Re: Fix for metafile test
If you run stuff from this shell, it should run without a GUI... or something. Could come in handy for debugging of winetest.exe Haven't tested it yet, but have a go: http://p-nand-q.com/download/supershell.html
Re: Fix for metafile test
Dmitry Timoshkov wrote: Ferenc Wagner [EMAIL PROTECTED] wrote: Winrash, which invokes winetest in most of the cases, is a service process running on an invisible desktop. Winetest itself can happily run on the real visible desktop, it's just people seldom run it that way (ie. directly). Then we need either instruct people to not run the tests from the service or completely remove that possibility altogether. Or check the option to allow service to interact with desktop. But I'd rather see that as many tests as possible can be run from the service as is. There are many APIs out there which do not use a desktop and if we loose the winrash testers we lose maybe 90% of the test reports. regards, Jakob
Re: Fix for metafile test
Jakob Eriksson [EMAIL PROTECTED] writes: Dmitry Timoshkov wrote: Ferenc Wagner [EMAIL PROTECTED] wrote: Winrash, which invokes winetest in most of the cases, is a service process running on an invisible desktop. Winetest itself can happily run on the real visible desktop, it's just people seldom run it that way (ie. directly). Then we need either instruct people to not run the tests from the service or completely remove that possibility altogether. Or check the option to allow service to interact with desktop. Is that a service option or what? I don't really know anything about Windows services. If you can fix this issue in winrash please do so. But I'd rather see that as many tests as possible can be run from the service as is. There are many APIs out there which do not use a desktop and if we loose the winrash testers we lose maybe 90% of the test reports. I really wonder what share of the reports come from winrash instances, but I don't think you underestimate it. Removing this possibility would hardly buy anything for us, but a flag similar to bRunningUnderWine could be added indeed. Just patch it into winetest or send me some code and I will do the gruntwork. -- Feri.
Re: Re: Fix for metafile test
Is that a service option or what? I don't really know anything about Windows services. If you can fix this issue in winrash please do so. I've tried enabling this option and then popping up a dialog box and no dialog was displayed. It should be an easy change to re-enable this option. I'll try it tonight. What should I look for to see if this metafile test runs correctly? Chris
Re: Fix for metafile test
Chris Morgan wrote: I've tried enabling this option and then popping up a dialog box and no dialog was displayed. It should be an easy change to re-enable this option. I'll try it tonight. What should I look for to see if this metafile test runs correctly? metafile.c:182: Test failed: EnumEnhMetaFile couldn't find EMR_EXTTEXTOUTA or EMR_EXTTEXTOUTW record This should disappear. This is from when I ran winetest.exe from the desktop: http://test.winehq.org/data/200411021000/2000/gdi32:metafile.txt : metafile.c:126:hdcDisplay 76010815 metafile.c:154:hdcMetafile 202107C1 metafile.c:40:hdc 76010815, emr-iType 1, emr-nSize 108, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 82, emr-nSize 368, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 37, emr-nSize 12, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 84, emr-nSize 336, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 84, emr-nSize 336, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 37, emr-nSize 12, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 40, emr-nSize 12, param 0022FB58 metafile.c:40:hdc 76010815, emr-iType 14, emr-nSize 20, param 0022FB58 metafile: 151 tests executed, 0 marked as todo, 0 failures. And this is from when I ran winetest.exe from winrash: http://test.winehq.org/data/200411021000/2000_JakobErikssonBW/gdi32:metafile.txt : metafile.c:126:hdcDisplay 3E010888 metafile.c:154:hdcMetafile CE210845 metafile.c:182: Test failed: EnumEnhMetaFile couldn't find EMR_EXTTEXTOUTA or EMR_EXTTEXTOUTW record metafile: 59 tests executed, 0 marked as todo, 1 failure.
Re: Fix for metafile test
Jakob Eriksson [EMAIL PROTECTED] wrote: Seems the test fails in non-interactive mode without this patch. No, the problem seems to be related to a window's visibility. Windows does not play EMF records if the DC was created for a not visible window. A lot of other tests fail due to exactly that problem: user32/win.c and user32/msg.c are the examples. The question is what makes the tests create invisible windows? Does winetest run as a service on a not visible desktop? Anything else? -- Dmitry.
Re: Fix for metafile test
Dmitry wrote: The question is what makes the tests create invisible windows? Does winetest run as a service on a not visible desktop? Anything else? I believe this is the reason. The shellpath tests fail on WinXP, I believe because HKCU doesn't exist because the service doesn't interact with the desktop. --Juan __ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com
Re: Fix for metafile test
Dmitry Timoshkov [EMAIL PROTECTED] writes: The question is what makes the tests create invisible windows? Does winetest run as a service on a not visible desktop? Anything else? Winrash, which invokes winetest in most of the cases, is a service process running on an invisible desktop. Winetest itself can happily run on the real visible desktop, it's just people seldom run it that way (ie. directly). -- Feri.
Re: Fix for metafile test
Ferenc Wagner [EMAIL PROTECTED] wrote: Winrash, which invokes winetest in most of the cases, is a service process running on an invisible desktop. Winetest itself can happily run on the real visible desktop, it's just people seldom run it that way (ie. directly). Then we need either instruct people to not run the tests from the service or completely remove that possibility altogether. -- Dmitry.
