I'm not sure why it was rejected

2013-10-02 Thread Akira Nakagawa 

  
  
I cannnot make sure my patch

99266 was
rejected.

Re: I'm not sure why it was rejected

2013-10-02 Thread Bruno Jesus 
On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa matyapir...@gmail.com wrote:
 I cannnot make sure my patch 99266 was rejected.

I can't really tell why it was rejected but I can tell there are mixed
space/tabs in the SetLastError lines.

I guess if you SetLastError to not implemented you cannot return S_OK too

Try comparing your patch with other patches that added new dlls. It
looks like you're missing the changes in configure and Makefile.in.
http://source.winehq.org/git/wine.git/?a=searchh=HEADst=commits=new+dll

Regards,
Bruno

Re: I'm not sure why it was rejected

2013-10-02 Thread Marcus Meissner 
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote:
 On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa matyapir...@gmail.com wrote:
  I cannnot make sure my patch 99266 was rejected.
 
 I can't really tell why it was rejected but I can tell there are mixed
 space/tabs in the SetLastError lines.
 
 I guess if you SetLastError to not implemented you cannot return S_OK too
 
 Try comparing your patch with other patches that added new dlls. It
 looks like you're missing the changes in configure and Makefile.in.
 http://source.winehq.org/git/wine.git/?a=searchh=HEADst=commits=new+dll

no, he is not as they are autogenerated.

Last open issue was the incorrect licenses.

Ciao, Marcus

Re: I'm not sure why it was rejected

2013-10-02 Thread Vincent Povirk 
 I guess if you SetLastError to not implemented you cannot return S_OK too

It doesn't make sense to use SetLastError at all for functions
returning HRESULT.