Re: Kernel32 profile/INI mappings to registry

2009-03-02 Thread Nikolay Sivov
Silver Blade wrote:
> Hi guys,
>  
> Whilst looking into some winmm.dll modifications for ReactOS, I found 
> that the Drivers and Drivers32 registry keys (used for determining the 
> wavemapper, midi devices etc.) effectively replace those entries found 
> in SYSTEM.INI of previous Windows versions.
>  
> Looking around in the registry reveals that Windows has a set of 
> registry keys that effectively map INI file sections to other registry 
> keys.
>
> This mapping is handled by the various "profile" APIs exported by 
> kernel32, and is described on MSDN for the "GetPrivateProfileString" API:
> http://msdn.microsoft.com/en-us/library/ms724353(VS.85).aspx# 
> 
>  
> Since ReactOS imports WINE's kernel32, I checked WINE's kernel32 
> source code and found that this mapping doesn't take place.
>  
> This in itself doesn't pose a problem - INI files work, after all! 
> However IMO it may be worth implementing this functionality, and this 
> is something I would be interested in doing. It makes more sense (to 
> me anyway) to implement this in WINE rather than directly in ReactOS. 
> And it seems relatively trivial.
>  
> Just thought I'd post here and gather any thoughts on this?
>  
> Regards,
>  
>  
> Andrew Greenwood
Hi, Andrew. Just make patches a post them to wine-patc...@winehq.org 
using this guide http://www.winehq.org/sending_patches

P.S. http://bugs.winehq.org/show_bug.cgi?id=4096
P.P.S. Never use ReactOS sources or any other product of reverse 
engineering implementing wine modules.




Kernel32 profile/INI mappings to registry

2009-03-02 Thread Silver Blade

Hi guys,

 

Whilst looking into some winmm.dll modifications for ReactOS, I found that the 
Drivers and Drivers32 registry keys (used for determining the wavemapper, midi 
devices etc.) effectively replace those entries found in SYSTEM.INI of previous 
Windows versions.

 

Looking around in the registry reveals that Windows has a set of registry keys 
that effectively map INI file sections to other registry keys.


This mapping is handled by the various "profile" APIs exported by kernel32, and 
is described on MSDN for the "GetPrivateProfileString" API:

http://msdn.microsoft.com/en-us/library/ms724353(VS.85).aspx#

 

Since ReactOS imports WINE's kernel32, I checked WINE's kernel32 source code 
and found that this mapping doesn't take place.

 

This in itself doesn't pose a problem - INI files work, after all! However IMO 
it may be worth implementing this functionality, and this is something I would 
be interested in doing. It makes more sense (to me anyway) to implement this in 
WINE rather than directly in ReactOS. And it seems relatively trivial.

 

Just thought I'd post here and gather any thoughts on this?

 

Regards,

 

 

Andrew Greenwood

_
 25GB of FREE Online Storage – Find out more
http://clk.atdmt.com/UKM/go/134665320/direct/01/