Re: Mozilla ActiveX download busted?
Le dimanche 12 février 2006 à 17:35 -0800, Dan Kegel a écrit :
Trying to install Oregon Trail from cnet download,
http://www.download.com/Oregon-Trail-5th-Edition/3000-7502_4-10301783.html
Cnet has you download a tiny .exe that invokes
IE via ActiveX to do the real download.
This pops up Wine's Mozilla ActiveX downloader dialog (great)
which then downloads the ActiveX wrapper (great)
but stores it in c:\windows\temp\mozactivex (note the lack of a .exe, uh-oh),
and shortly thereafter prints
wine: could not load LC:\\windows\\temp\\mozactivex as Win32 binary
Wine's Mozilla ActiveX downloader dialog just sits there forever,
it doesn't seem to notice the problem.
Renaming mozactivex to mozactivex.exe and then running it manually
got me past that little problem -- I'm no longer prompted to download
wine's mozilla activex wrapper.
This worked better a month or two ago - what changed?
(I'd do a regression test myself, but can't afford to type too much...)
- Dan
Wine doesn't accept to run files that don't end with .exe even if they
are valid win32 binaries.
Changelog:
- ensure that the mozilla activex control downloaded ends with .exe
because Wine won't run it otherwise
Index: dlls/shdocvw/shdocvw_main.c
===
RCS file: /home/wine/wine/dlls/shdocvw/shdocvw_main.c,v
retrieving revision 1.41
diff -u -p -r1.41 shdocvw_main.c
--- dlls/shdocvw/shdocvw_main.c 15 Feb 2006 13:04:28 - 1.41
+++ dlls/shdocvw/shdocvw_main.c 21 Feb 2006 17:24:46 -
@@ -297,6 +297,7 @@ static DWORD WINAPI ThreadFunc( LPVOID i
IBindStatusCallback *dl;
static const WCHAR szUrlVal[] = {'M','o','z','i','l','l','a','U','r','l',0};
static const WCHAR szFileProtocol[] = {'f','i','l','e',':','/','/','/',0};
+static const WCHAR szExe[] = {'.','e','x','e',0};
WCHAR path[MAX_PATH], szUrl[MAX_PATH];
LPWSTR p;
STARTUPINFOW si;
@@ -331,6 +332,8 @@ static DWORD WINAPI ThreadFunc( LPVOID i
if (!GetTempPathW( MAX_PATH, path ))
goto end;
strcatW( path, p+1 );
+/* ensure that the path ends with .exe, because wine won't run it otherwise */
+strcatW( path, szExe );
/* download it */
bTempfile = TRUE;
Re: Mozilla ActiveX download busted?
Hi, On Tue, Feb 21, 2006 at 06:26:16PM +0100, Jonathan Ernst wrote: Wine doesn't accept to run files that don't end with .exe even if they are valid win32 binaries. Changelog: - ensure that the mozilla activex control downloaded ends with .exe because Wine won't run it otherwise There's strong reason to believe that you don't know Alexandre's ha^^Hpatch quality rules at all ;) It'd be useful to get this problem fixed For Real, but that may require some investigation, unfortunately. Andreas
Re: Mozilla ActiveX download busted?
Andreas Mohr wrote: Hi, On Tue, Feb 21, 2006 at 06:26:16PM +0100, Jonathan Ernst wrote: Wine doesn't accept to run files that don't end with .exe even if they are valid win32 binaries. Changelog: - ensure that the mozilla activex control downloaded ends with .exe because Wine won't run it otherwise There's strong reason to believe that you don't know Alexandre's ha^^Hpatch quality rules at all ;) It'd be useful to get this problem fixed For Real, but that may require some investigation, unfortunately. The fix looks good to me, provided that the extension is only added if it doesn't already have one. I don't think it is that unreasonable to expect an executable to have a .exe extension. -- Rob Shearman
Re: Mozilla ActiveX download busted?
Andreas Mohr [EMAIL PROTECTED] writes: On Tue, Feb 21, 2006 at 06:26:16PM +0100, Jonathan Ernst wrote: Wine doesn't accept to run files that don't end with .exe even if they are valid win32 binaries. Changelog: - ensure that the mozilla activex control downloaded ends with .exe because Wine won't run it otherwise There's strong reason to believe that you don't know Alexandre's ha^^Hpatch quality rules at all ;) It'd be useful to get this problem fixed For Real, but that may require some investigation, unfortunately. That was a bug I introduced in my recent loader changes, it should be fixed now. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Mozilla ActiveX download busted?
On Tue, 21 Feb 2006, Robert Shearman wrote: [...] Andreas Mohr wrote: Hi, On Tue, Feb 21, 2006 at 06:26:16PM +0100, Jonathan Ernst wrote: Wine doesn't accept to run files that don't end with .exe even if they are valid win32 binaries. [...] The fix looks good to me, provided that the extension is only added if it doesn't already have one. I don't think it is that unreasonable to expect an executable to have a .exe extension. I'm ok with the patch itself: if we download an executable it's a good thing to give it a .exe extension to give a hint so the user who later wonders what this file is. However CreateProcess() should really not care about the file extension. Testing on Windows 2003ES shows that ren foo.exe foo, CreateProcess(foo) works just fine. -- Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.
Mozilla ActiveX download busted?
Trying to install Oregon Trail from cnet download, http://www.download.com/Oregon-Trail-5th-Edition/3000-7502_4-10301783.html Cnet has you download a tiny .exe that invokes IE via ActiveX to do the real download. This pops up Wine's Mozilla ActiveX downloader dialog (great) which then downloads the ActiveX wrapper (great) but stores it in c:\windows\temp\mozactivex (note the lack of a .exe, uh-oh), and shortly thereafter prints wine: could not load LC:\\windows\\temp\\mozactivex as Win32 binary Wine's Mozilla ActiveX downloader dialog just sits there forever, it doesn't seem to notice the problem. Renaming mozactivex to mozactivex.exe and then running it manually got me past that little problem -- I'm no longer prompted to download wine's mozilla activex wrapper. This worked better a month or two ago - what changed? (I'd do a regression test myself, but can't afford to type too much...) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv
