Re: RFC: EM_FORMATRANGE Patch for Wine-1.1.33

2009-11-30 Thread James McKenzie 
Dan Kegel wrote:
> I can't do a deep review, but I did see that you have some
> commented out code, and IIRC AJ doesn't like that.  Better
> to remove it than comment it out.
>   
Point taken.  I still would like to know where to break this up.  I know
that the removal of the todo_wine should be separate from the main patch
body.
> BTW, besides the three apps mentioned in
> http://bugs.winehq.org/show_bug.cgi?id=6254,
> what apps depend on this?
>   
I don't know.  I had several apps that did not run under wine-1.1.6 but
do under wine-1.1.7.  I'm looking at this as well as the mismatched size
of the Print Preview for Wordpad/Wordpad.exe.

James McKenzie

re: RFC: EM_FORMATRANGE Patch for Wine-1.1.33

2009-11-29 Thread Dan Kegel 
I can't do a deep review, but I did see that you have some
commented out code, and IIRC AJ doesn't like that.  Better
to remove it than comment it out.

BTW, besides the three apps mentioned in
http://bugs.winehq.org/show_bug.cgi?id=6254,
what apps depend on this?
- Dan

RFC: EM_FORMATRANGE Patch for Wine-1.1.33

2009-11-29 Thread James McKenzie 
All:

Time to beat on this patch again and make it better.  I've also attached
it to bug 6254.

Please make comments constructive.  I would like to get assistance where
to break this down so that it will be 'easier to swallow' pieces as this
is one huge patch that AJ has rejected before.

James McKenzie



0001-EM_FORMATRANGE-Patch-for-Wine-1.1.33.patch
Description: application/text