Re: [PATCH] kernel32: Output message to stderr in UTF-8

2011-10-25 Thread Alex Henrie 
Hello,

Last week I submitted a patch to make kernel32 output an error message
in UTF-8 rather than the current codepage. This fixed a bug in which
the command wine /. would produce a garbled error message in
languages other than English. However, thinking about this some more,
I'm not sure that my patch fixes the bug correctly. I made
WideCharToMultiByte use CP_UTF8 instead of CP_ACP, but reading more
about the codepage setting, I think I should have used either
CP_UNIXCP or CP_OEMCP. Could anyone help clarify which should be used?

-Alex

Re: [PATCH] kernel32: Output message to stderr in UTF-8

2011-10-25 Thread Nicolas Le Cam 
2011/10/25 Alex Henrie alexhenri...@gmail.com:
 Hello,

 Last week I submitted a patch to make kernel32 output an error message
 in UTF-8 rather than the current codepage. This fixed a bug in which
 the command wine /. would produce a garbled error message in
 languages other than English. However, thinking about this some more,
 I'm not sure that my patch fixes the bug correctly. I made
 WideCharToMultiByte use CP_UTF8 instead of CP_ACP, but reading more
 about the codepage setting, I think I should have used either
 CP_UNIXCP or CP_OEMCP. Could anyone help clarify which should be used?

 -Alex


See Dmitry response to your patch :
http://article.gmane.org/gmane.comp.emulators.wine.devel/87295


-- 
Nicolas Le Cam

Re: [PATCH] kernel32: Output message to stderr in UTF-8

2011-10-19 Thread Dmitry Timoshkov 
Alex Henrie alexhenri...@gmail.com wrote:

 -WideCharToMultiByte( CP_ACP, 0, msgW, -1, msg, sizeof(msg), NULL, 
 NULL );
 +WideCharToMultiByte( CP_UTF8, 0, msgW, -1, msg, sizeof(msg), NULL, 
 NULL );
  MESSAGE( wine: %s, msg );

Try CP_UNIXCP intead.

-- 
Dmitry.