Re: [PATCH] shell32: Clear a pointer on failure in XDG_UserDirLookup.

2008-07-21 Thread Lei Zhang
On Mon, Jul 21, 2008 at 1:41 PM, Lei Zhang <[EMAIL PROTECTED]> wrote:
> On Wed, Jul 16, 2008 at 12:54 PM, Lei Zhang <[EMAIL PROTECTED]> wrote:
>> Hi,
>>
>> We should clear the out pointer on failure, so the caller won't access bad 
>> data.
>>
>
> Anything wrong with this patch? Should I check the return value from
> XDG_UserDirLookup() instead?
>

Nevermind, just saw commit de3afabf.




Re: [PATCH] shell32: Clear a pointer on failure in XDG_UserDirLookup.

2008-07-21 Thread Lei Zhang
On Wed, Jul 16, 2008 at 12:54 PM, Lei Zhang <[EMAIL PROTECTED]> wrote:
> Hi,
>
> We should clear the out pointer on failure, so the caller won't access bad 
> data.
>

Anything wrong with this patch? Should I check the return value from
XDG_UserDirLookup() instead?