Re: DINPUT device unacquire (mouse) fix
Andreas Mohr wrote: But don't you think keyboard and joystick might need the same code?? (keyboard has it as well, but with completely different code --> mess) Umm correction to my last post, keyboard already has this working with different code just like you said. (I initially didn't see the implementation, sloppy work) That leaves just the joystick to be fixed. - Hannu Valtonen [EMAIL PROTECTED]
Re: DINPUT device unacquire (mouse) fix
Andreas Mohr wrote: But don't you think keyboard and joystick might need the same code?? (keyboard has it as well, but with completely different code --> mess) This could probably be cleaned up. I have a patch semi-ready which does the same for keyboard/joystick using the existing scheme.. but I was wondering whether or not we should clean up this mess? Any opinions? Should I a) send the fixes for keyboard/joystick using the existing scheme or b) should we start reusing/cleaning the code? If the answer turns out to be b) and you/someone else doesn't want to take the job I'm going to need a bit of handholding as I'm rather new to Wine development. - Hannu Valtonen [EMAIL PROTECTED]
Re: DINPUT device unacquire (mouse) fix
Hi, On Tue, Oct 28, 2003 at 02:53:44AM +0200, Hannu Valtonen wrote: > License: LGPL > > I stumbled upon this when looking at fixing mouse support for Crimson > lands. According to MSDN DirectInputDevice Unacquire is allowed even for > devices which haven't been acquired yet. > > Changelog: > - SysMouseAImpl_Unacquire should return DI_NOEFFECT if the device is not > in an acquired state. Ah, thanks!! Maybe this is why some game (I believe it was UT) broke... Darn, why didn't I discover that when I stumbled on that place years ago? But don't you think keyboard and joystick might need the same code?? (keyboard has it as well, but with completely different code --> mess) This could probably be cleaned up. Andreas Mohr
