Re: Perform automatic bitmap font configuration. Take 4

2005-09-13 Thread Huw D M Davies 
On Tue, Sep 13, 2005 at 04:45:30PM +0900, Dmitry Timoshkov wrote:
  
 +static const struct nls_update_font_list
 +{
 +UINT ansi_cp;
 +const char *oem, *fixed, *system;
 +const char *courier, *serif, *small, *sserif;
 +} nls_update_font_list[] =

Hi Dmitry,

I think you also need to take into account the OEM codepage here.  For
example in the UK the OEM font would be vga850.fon while in the US it
would be vgaoem.fon.

Huw.

Re: Perform automatic bitmap font configuration. Take 4

2005-09-13 Thread Dmitry Timoshkov 
Huw D M Davies [EMAIL PROTECTED] wrote:

 I think you also need to take into account the OEM codepage here.  For
 example in the UK the OEM font would be vga850.fon while in the US it
 would be vgaoem.fon.

Once Alexandre accepts the patch I'll send the fix, it should be a small
one.

-- 
Dmitry.

Re: Perform automatic bitmap font configuration. Take 4

2005-09-13 Thread Huw D M Davies 
On Tue, Sep 13, 2005 at 06:21:22PM +0900, Dmitry Timoshkov wrote:
 Huw D M Davies [EMAIL PROTECTED] wrote:
 
  I think you also need to take into account the OEM codepage here.  For
  example in the UK the OEM font would be vga850.fon while in the US it
  would be vgaoem.fon.
 
 Once Alexandre accepts the patch I'll send the fix, it should be a small
 one.

Fair enough.  I'd suggest separating the ansi fonts from the oem fonts
and installing them according to the appropiate codepage.

One other thing about your patch - I don't think we want the magic
registry comment above the external fonts registry key, as this isn't
user configurable data, it's just internal housekeeping.

Huw.

Re: Perform automatic bitmap font configuration. Take 4

2005-09-13 Thread Dmitry Timoshkov 
Huw D M Davies [EMAIL PROTECTED] wrote:

 One other thing about your patch - I don't think we want the magic
 registry comment above the external fonts registry key, as this isn't
 user configurable data, it's just internal housekeeping.

I've just added the comment to make it look similar to the earlier
occurence of 'if(RegCreateKeyExW(HKEY_CURRENT_USER, external_fonts_reg_key'
in that file.

-- 
Dmitry.

Re: Perform automatic bitmap font configuration. Take 4

2005-09-13 Thread Alexandre Julliard 
Dmitry Timoshkov [EMAIL PROTECTED] writes:

 @@ -313,10 +312,7 @@ void LOCALE_InitRegistry(void)
  }
  else TRACE( updating registry, locale changed none - %08lx\n, lcid );
  
 -sprintf( buffer, %08lx, lcid );
 -/* Note: '9' constant below is strlen(buffer) + 1 */
 -RtlMultiByteToUnicodeN( bufferW, sizeof(bufferW), NULL, buffer, 9 );
 -NtSetValueKey( hkey, nameW, 0, REG_SZ, bufferW, 9 * sizeof(WCHAR) );
 +/* GDI32 detects locale change as well, it will update the registry */

You can't depend on GDI updating the kernel's key, they need to be
independent.

-- 
Alexandre Julliard
[EMAIL PROTECTED]