Re: Problem detecting libxslt
Vincent Béron [EMAIL PROTECTED] writes: Is this acceptable? libxslt/xslt.h was never included, so I got rid of it. The variable declarations weren't protected with the HAVE_LIBXSLT_*_H macros, so I simplified the test and removed the macros. I think keeping the standard header check is better. What didn't work with your previous solution? -- Alexandre Julliard [EMAIL PROTECTED]
Re: Problem detecting libxslt
Le mer 14/09/2005 à 06:20, Alexandre Julliard a écrit : Vincent Béron [EMAIL PROTECTED] writes: Is this acceptable? libxslt/xslt.h was never included, so I got rid of it. The variable declarations weren't protected with the HAVE_LIBXSLT_*_H macros, so I simplified the test and removed the macros. I think keeping the standard header check is better. What didn't work with your previous solution? Nothing, I simply misunderstood your comment Looks good to me while answering Mike's proposal of an AC_TRY_COMPILE() test, and the patch wasn't applied yet, so I jumped to some wrong conclusions :) Note that libxslt/xslt.h is still unused in Wine's code, so I don't see why we check for it. Also, even if the header inclusion is protected, variable declarations using types from those headers are not, so if one is missing you'll still get a compilation error during make. I'll resubmit the first patch with the libxslt/xslt.h check removed. Vincent
Re: Problem detecting libxslt
Vincent Béron wrote: --- configure.ac3 Sep 2005 15:43:53 - 1.403 +++ configure.ac8 Sep 2005 23:08:04 - @@ -469,7 +469,10 @@ then [AC_DEFINE(HAVE_LIBXSLT, 1, [Define if you have the libxslt library]) XSLTLIBS=$ac_xslt_libs XSLTINCL=$ac_xslt_cflags],,$ac_xslt_libs) -]) +],, +[#ifdef HAVE_LIBXSLT_PATTERN_H +# include libxslt/pattern.h +#endif]) CPPFLAGS=$ac_save_CPPFLAGS fi It doesn't seem exactly right to me, but I'm not really sure of a better way of fixing it. Maybe an AC_TRY_COMPILE()? Alexandre understands configure better than I do, so you might try asking him. Mike
Re: Problem detecting libxslt
Mike McCormack [EMAIL PROTECTED] writes: It doesn't seem exactly right to me, but I'm not really sure of a better way of fixing it. Maybe an AC_TRY_COMPILE()? Alexandre understands configure better than I do, so you might try asking him. Looks good to me. -- Alexandre Julliard [EMAIL PROTECTED]
