Re: cmd: mkdir should complain if directory already exists (try 2)

2011-07-26 Thread Frédéric Delanoy 
On Tue, Jul 26, 2011 at 07:39, Dan Kegel  wrote:
> Changes since last try:
> - fix remaining todo_wine's
> - add one more testcase for invalid paths (one that doesn't trigger
> help message)
> - simplified create_full_path
> - avoid generating error message in race case where somebody else
> creates an intermediate directory first

Maybe a bit nitpickings, but
echo mkdir foo slash star errorlevel %ErrorLevel%

could be more readable with
echo mkdir foo/* errorlevel %ErrorLevel%

/ and * are not to be escaped, so don't mind expanding them "litteraly"

Frédéric

Re: cmd: mkdir should complain if directory already exists

2011-07-24 Thread Frédéric Delanoy 
On Sun, Jul 24, 2011 at 20:58, Dan Kegel  wrote:
> Fixes bug 27383.

There's trailing whitespace on the line preceding  "if
(!create_full_path(param1)) {"
Seems ok otherwise