Re: comctl32: Fix statusbar text alignment bug #12693
On Tue, May 13, 2008 at 8:35 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > > On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <[EMAIL PROTECTED]> > wrote: > > > > > MSDN regarding statusbar text alignment says that "By default, text is > > > left-aligned <...> Text to the right of a single tab character is > > > centered, and text to the right of a second tab character is > > > right-aligned.". Current implementation, however, could be described > > > as "if the first character is tab, center the text. Then check second > > > character, if it is tab too, left-align the text". This patch makes > > > wine behave more like MSDN says and fixes bug > > > http://bugs.winehq.org/show_bug.cgi?id=12693 . > > > > > > > > > > Please add a test case to prove this change is correct. > > > > Since I reviewed initial Igor's attempts, and helped a bit, I don't see > a way how this behaviour can possibly be tested, that's a pure visual > thing, and Igor says that he has been testing his patch extensively with > ControlSpy. > Ok that's fair. I wasn't sure if it was possible to test or not. -- James Hawkins
Re: comctl32: Fix statusbar text alignment bug #12693
"James Hawkins" <[EMAIL PROTECTED]> wrote: > On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <[EMAIL PROTECTED]> wrote: >> MSDN regarding statusbar text alignment says that "By default, text is >> left-aligned <...> Text to the right of a single tab character is >> centered, and text to the right of a second tab character is >> right-aligned.". Current implementation, however, could be described >> as "if the first character is tab, center the text. Then check second >> character, if it is tab too, left-align the text". This patch makes >> wine behave more like MSDN says and fixes bug >> http://bugs.winehq.org/show_bug.cgi?id=12693 . >> > > Please add a test case to prove this change is correct. Since I reviewed initial Igor's attempts, and helped a bit, I don't see a way how this behaviour can possibly be tested, that's a pure visual thing, and Igor says that he has been testing his patch extensively with ControlSpy. -- Dmitry.
Re: comctl32: Fix statusbar text alignment bug #12693
On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <[EMAIL PROTECTED]> wrote: > MSDN regarding statusbar text alignment says that "By default, text is > left-aligned <...> Text to the right of a single tab character is > centered, and text to the right of a second tab character is > right-aligned.". Current implementation, however, could be described > as "if the first character is tab, center the text. Then check second > character, if it is tab too, left-align the text". This patch makes > wine behave more like MSDN says and fixes bug > http://bugs.winehq.org/show_bug.cgi?id=12693 . > Please add a test case to prove this change is correct. -- James Hawkins
