Re: gdiplus: Implement GdipCreateHBITMAPFromBitmap

2009-04-29 Thread Massimo Del Fedele

Nikolay Sivov ha scritto:

Massimo Del Fedele wrote:

Massimo Del Fedele ha scritto:
Should work for both DIBs and DDBs format, but strange enough the 
IPicture bitmap
inside wine gdiplus bitmap is always a 32 bit DDB by now... haven't 
found any

other case.

Ciao

Max






sorry again... another dumb copy/paste :-(
Former had a spurious FIXME used for debugging purposes

Max

+IPicture_get_Handle(bitmap->image.picture, (OLE_HANDLE*)&hbm);
+if(!hbm)
+/* FIXME: return appropriate error code */
+return GenericError;
+
+/* gets bitmap data and find out bitmap's type */
+if(!(size = GetObjectW(hbm, sizeof(DIBSECTION), &ds)))
+{
+ERR("Couldn't get bitmap data\n");
+return GenericError;
+}

Could be HICON here (see GdipCreateBitmapFromHICON) or metafile.
Since there's no tests for that could you please an explicit FIXME for
that types?







Done, thank you for the hint :-)

Ciao

Max





Re: gdiplus: Implement GdipCreateHBITMAPFromBitmap

2009-04-29 Thread Nikolay Sivov

Massimo Del Fedele wrote:

Massimo Del Fedele ha scritto:
Should work for both DIBs and DDBs format, but strange enough the 
IPicture bitmap
inside wine gdiplus bitmap is always a 32 bit DDB by now... haven't 
found any

other case.

Ciao

Max






sorry again... another dumb copy/paste :-(
Former had a spurious FIXME used for debugging purposes

Max

+IPicture_get_Handle(bitmap->image.picture, (OLE_HANDLE*)&hbm);
+if(!hbm)
+/* FIXME: return appropriate error code */
+return GenericError;
+
+/* gets bitmap data and find out bitmap's type */
+if(!(size = GetObjectW(hbm, sizeof(DIBSECTION), &ds)))
+{
+ERR("Couldn't get bitmap data\n");
+return GenericError;
+}

Could be HICON here (see GdipCreateBitmapFromHICON) or metafile.
Since there's no tests for that could you please an explicit FIXME for
that types?