Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)

2012-07-25 Thread Marvin 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=84

Your paranoid android.


=== debiantesting (build) ===
Patch failed to apply

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)

2012-06-26 Thread Alexandre Julliard 
André Hentschel n...@dawncrow.de writes:

 @@ -2625,6 +2641,28 @@ INT WINAPI LCMapStringW(LCID lcid, DWORD flags, 
 LPCWSTR src, INT srclen,
  }
  
  /*
 + *   LCMapStringW(KERNEL32.@)
 + *
 + * See LCMapStringA.
 + */
 +INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen,
 +LPWSTR dst, INT dstlen)
 +{
 +WCHAR locale[LOCALE_NAME_MAX_LENGTH];
 +
 +TRACE((0x%04x,0x%08x,%s,%d,%p,%d)\n,
 +  lcid, flags, debugstr_wn(src, srclen), srclen, dst, dstlen);
 +
 +if (!LCIDToLocaleName(lcid, locale, LOCALE_NAME_MAX_LENGTH, 0))
 +{
 +SetLastError(ERROR_INVALID_PARAMETER);
 +return 0;
 +}

I don't think it makes sense to do name conversion for a parameter that
isn't used. If we use it someday it will most likely be to look up a
conversion table directly from the lcid.

-- 
Alexandre Julliard
julli...@winehq.org