Re: winmm: Add support for "open new" commands.
2006/6/11, Eric Pouech <[EMAIL PROTECTED]>:
Peter Åstrand wrote:> On Sat, 10 Jun 2006, Eric Pouech wrote: ChangeLog:
>>> winmm: Add support for "open new" commands.>> looks globally good, except that you don't enforce that you got a>> correct device name ie I'm not sure that 'open new type waveaudio'
>> works (without the alias)>>> I'm not sure I understand what you mean, how is the alias related to> the verification of a correct device name?it's not. but I don't think a command like 'open new type waveaudio'
shall work (as the name of the MCI device would be new in that case,which is a reserved keyword). In other words, I think that 'open new'should fail if no alias is given.
for the sake of completeness, I tested it on Windows:
mciSendString("open new type wavedaudio", ...) fails with the error MCIERR_NEW_REQUIRES_ALIAS. This must be properly handled before submission into Wine.
A+
-- Eric Pouech
Re: winmm: Add support for "open new" commands.
Peter Åstrand wrote: On Sat, 10 Jun 2006, Eric Pouech wrote: ChangeLog: winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) I'm not sure I understand what you mean, how is the alias related to the verification of a correct device name? it's not. but I don't think a command like 'open new type waveaudio' shall work (as the name of the MCI device would be new in that case, which is a reserved keyword). In other words, I think that 'open new' should fail if no alias is given. Perhaps the patch can be applied with a FIXME for the case you are talking about, since we would then at least have partial support for "open new"? that shouldn't be too hard to add. A+
Re: winmm: Add support for "open new" commands.
On Sat, 10 Jun 2006, Eric Pouech wrote: ChangeLog: winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) I'm not sure I understand what you mean, how is the alias related to the verification of a correct device name? Perhaps the patch can be applied with a FIXME for the case you are talking about, since we would then at least have partial support for "open new"? Regards, -- Peter Åstrand ThinLinc Chief Developer Cendio http://www.cendio.se Teknikringen 3 583 30 LinköpingPhone: +46-13-21 46 00
Re: winmm: Add support for "open new" commands.
Peter Åstrand wrote: ChangeLog: winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) A+
