Re: Valgrind warnings in new msxml3 saxreader code?

2008-07-23 Thread Piotr Caban
Hi Dan,
I have send patches fixing some of the valgrind warnings. I'll look over rest 
of them when the patches are accepted and valgrind logs updated.

Regards,
Piotr




Valgrind warnings in new msxml3 saxreader code?

2008-07-21 Thread Dan Kegel
Hi Piotr,
I see a lot of new valgrind warnings today that seem to be
triggered by your new msxml3 code.
I don't know offhand if they're bugs in libxml2 or in your code,
could you have a look?
Thanks!

See
http://kegel.com/wine/valgrind/logs/2008-07-21-07.56/vg-msxml3_saxreader-diff.txt

Here are the first two:

 Conditional jump or move depends on uninitialised value(s)
at  xmlStrlen (in /usr/lib/libxml2.so.2.6.31)
by  xmlSetupParserForBuffer (in /usr/lib/libxml2.so.2.6.31)
by  isaxxmlreader_parse (saxreader.c:1077)
by  test_saxreader (saxreader.c:502)
by  func_saxreader (saxreader.c:518)
by  run_test (test.h:488)
by  main (test.h:537)
  Uninitialised value was created by a client request
at  mark_block_uninitialized (heap.c:164)
by  RtlAllocateHeap (heap.c:1236)
by  SAFEARRAY_Malloc (safearray.c:94)
by  SafeArrayAllocData (safearray.c:536)
by  SAFEARRAY_Create (safearray.c:231)
by  SafeArrayCreate (safearray.c:576)
by  test_saxreader (saxreader.c:494)
by  func_saxreader (saxreader.c:518)
by  run_test (test.h:488)
by  main (test.h:537)

 Conditional jump or move depends on uninitialised value(s)
at  get_length_mbs_utf8 (utf8.c:286)
by  wine_utf8_mbstowcs (utf8.c:312)
by  MultiByteToWideChar (locale.c:1838)
by  bstr_from_xmlChar (node.c:284)
by  libxmlCharacters (saxreader.c:249)
by  xmlParseCharData (in /usr/lib/libxml2.so.2.6.31)
by  xmlParseContent (in /usr/lib/libxml2.so.2.6.31)
by  xmlParseElement (in /usr/lib/libxml2.so.2.6.31)
by  xmlParseDocument (in /usr/lib/libxml2.so.2.6.31)
by  isaxxmlreader_parse (saxreader.c:1083)
by  test_saxreader (saxreader.c:502)
by  func_saxreader (saxreader.c:518)
by  run_test (test.h:488)
by  main (test.h:537)
  Uninitialised value was created by a client request
at  mark_block_uninitialized (heap.c:164)
by  RtlAllocateHeap (heap.c:1236)
by  SAFEARRAY_Malloc (safearray.c:94)
by  SafeArrayAllocData (safearray.c:536)
by  SAFEARRAY_Create (safearray.c:231)
by  SafeArrayCreate (safearray.c:576)
by  test_saxreader (saxreader.c:494)
by  func_saxreader (saxreader.c:518)
by  run_test (test.h:488)
by  main (test.h:537)

...