Re: WIDL - Sync to ReactOS 20050308

2005-03-08 Thread Alexandre Julliard
Steven Edwards <[EMAIL PROTECTED]> writes:

> No one really got back to me on how handles should be done in the dcom.idl so 
> I am going assume
> this is correct. If this has gotten too big let me know and I can break it up 
> in to smaller
> patches over the next week.

Yes please, every separate change should be a separate patch.

-- 
Alexandre Julliard
[EMAIL PROTECTED]



Re: WIDL - Sync to ReactOS 20050308

2005-03-08 Thread Rob Shearman
Steven Edwards wrote:
No one really got back to me on how handles should be done in the dcom.idl so I am going assume
this is correct. If this has gotten too big let me know and I can break it up in to smaller
patches over the next week.
 

Sorry Steven, I meant to investigate this before but I forgot.
Index: dlls/ole32/dcom.idl
===
RCS file: /home/wine/wine/dlls/ole32/dcom.idl,v
retrieving revision 1.1
diff -u -b -r1.1 dcom.idl
--- dlls/ole32/dcom.idl 22 May 2003 03:36:26 -  1.1
+++ dlls/ole32/dcom.idl 8 Mar 2005 18:28:18 -
@@ -217,6 +217,7 @@
cpp_quote("#if 0")
[
+  explicit_handle,
  uuid(99fcfec4-5260-101b-bbcb-00aa0021347a),
  pointer_default(unique)
]
 

explicit_handle is an ACF attribute and not something that should 
normally be put in an IDL file. Furthermore, it is not necessary, as 
stated by MSDN:
"If the *[explicit_handle]* attribute is not used, the application can 
still specify that an operation have an explicit handle (binding or 
serialization) directing the call."
I think there is an MIDL command-line option to allow ACF attributes in 
IDL files though.

Rob