Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Alexandre Julliard 
Amine Khaldi  writes:

> On 06/09/2013 16:28, Alexandre Julliard wrote:
>> Amine Khaldi  writes:
>>
>>> @@ -18,15 +18,7 @@
>>>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, 
>>> USA
>>>   */
>>>  
>>> -#include "config.h"
>>> -
>>> -#include 
>>> -
>>>  #include "initguid.h"
>>> -#include "windef.h"
>>> -#include "winbase.h"
>>> -#include "winuser.h"
>>> -#include "winnt.h"
>>>  #include "aclui.h"
>> That's not useful. The headers will be included anyway.
>>
> Indeed. Are there some benefits of including them more than once here ?

No, but it's harmless, so there's no reason to change it.

-- 
Alexandre Julliard
julli...@winehq.org

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Amine Khaldi 
On 06/09/2013 16:28, Alexandre Julliard wrote:
> Amine Khaldi  writes:
>
>> @@ -18,15 +18,7 @@
>>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>>   */
>>  
>> -#include "config.h"
>> -
>> -#include 
>> -
>>  #include "initguid.h"
>> -#include "windef.h"
>> -#include "winbase.h"
>> -#include "winuser.h"
>> -#include "winnt.h"
>>  #include "aclui.h"
> That's not useful. The headers will be included anyway.
>
Indeed. Are there some benefits of including them more than once here ?

Regards,
Amine.

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Alexandre Julliard 
Amine Khaldi  writes:

> @@ -18,15 +18,7 @@
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>   */
>  
> -#include "config.h"
> -
> -#include 
> -
>  #include "initguid.h"
> -#include "windef.h"
> -#include "winbase.h"
> -#include "winuser.h"
> -#include "winnt.h"
>  #include "aclui.h"

That's not useful. The headers will be included anyway.

-- 
Alexandre Julliard
julli...@winehq.org