Re: comctl: allow label edit only if treeview style allows editing
2012/6/4 Dan Kegel : > I had the same problem, and wrote a little script to skip the bad tests. > It was written for buildbot, but can be run standalone. > Try downloading > http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh > and > http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt > then run > sh dotests.sh goodtests > That will skip all the tests known to hang or fail. (The list might be > a bit out of date, but it's easy to add new tests to the blacklist.) Now that's much better! Thank you. I slightly modified the script and found that 5 tests from the good list fail with native comctl. Good indicator of areas that need more love :) -- Regards, Daniel
re: comctl: allow label edit only if treeview style allows editing
> I stopped doing > make test on my machine some time ago Bad developer, no donut :-) > , when I found out that some > tests do consistently fail on my machine (clean prefix or not), and > others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to skip the bad tests. It was written for buildbot, but can be run standalone. Try downloading http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh and http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt then run sh dotests.sh goodtests That will skip all the tests known to hang or fail. (The list might be a bit out of date, but it's easy to add new tests to the blacklist.) > I don't install wine-gecko, maybe that's the reason. Run https://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh then you'll never have to install it again. (Until it's updated, anyway.) - Dan
Re: comctl: allow label edit only if treeview style allows editing
2012/6/4 Alexandre Julliard : > Daniel Jelinski writes: > >> From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 >> From: Daniel Jelinski >> Date: Sat, 2 Jun 2012 07:23:32 +0200 >> Subject: comctl: allow label edit only if treeview style allows editing >> >> Native comctl behaves this way - noticed when debugging regedit > > It breaks the tests: > > ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p > shell32_test.exe.so brsfolder.c && touch brsfolder.ok > brsfolder.c:225: Test failed: The new folder did not get the name foo > brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for > the new folder. Expected > 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' > got > 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New > Folder' > make: *** [brsfolder.ok] Error 2 Ah, thank you for this information. I'll look into it. I stopped doing make test on my machine some time ago, when I found out that some tests do consistently fail on my machine (clean prefix or not), and others consistently hang, thus preventing make test -k. I don't install wine-gecko, maybe that's the reason. -- Regards, Daniel
Re: comctl: allow label edit only if treeview style allows editing
Daniel Jelinski writes: > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski > Date: Sat, 2 Jun 2012 07:23:32 +0200 > Subject: comctl: allow label edit only if treeview style allows editing > > Native comctl behaves this way - noticed when debugging regedit It breaks the tests: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok brsfolder.c:225: Test failed: The new folder did not get the name foo brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' make: *** [brsfolder.ok] Error 2 -- Alexandre Julliard julli...@winehq.org
