Re: comctl32/imagelist: use proper color format for merged image lists (try 2)

2013-03-05 Thread Alexandre Julliard
Daniel Jelinski djelins...@gmail.com writes:

 +static void test_merge_colors(void)
 +{
 +HIMAGELIST himl[5], hmerge;
 +int sizes[] = { ILC_COLOR4, ILC_COLOR8, ILC_COLOR16, ILC_COLOR24, 
 ILC_COLOR32 };

You should also test COLORDDB, and probably the mask behavior too.

-- 
Alexandre Julliard
julli...@winehq.org




Re: comctl32/imagelist: use proper color format for merged image lists (try 2)

2013-03-05 Thread Daniel Jelinski
Hello,
No surprises in mask behavior - the result is always masked. On the
other hand, merging ILC_COLOR16 with ILC_COLORDDB (which is 32bit)
results in 16bit image:
https://testbot.winehq.org/JobDetails.pl?Key=24624
All other merges (including reverse of the above = ILC_COLORDDB with
ILC_COLOR16) use the greater of the color depths from source
imagelists.

Any idea what might be happening there?
Regards,
Daniel

2013/3/5 Alexandre Julliard julli...@winehq.org:
 Daniel Jelinski djelins...@gmail.com writes:

 +static void test_merge_colors(void)
 +{
 +HIMAGELIST himl[5], hmerge;
 +int sizes[] = { ILC_COLOR4, ILC_COLOR8, ILC_COLOR16, ILC_COLOR24, 
 ILC_COLOR32 };

 You should also test COLORDDB, and probably the mask behavior too.

 --
 Alexandre Julliard
 julli...@winehq.org