Re: comctl32: Remove dead increments (clang)

2011-07-26 Thread Reece Dunn 
2011/7/26 André Hentschel n...@dawncrow.de:
 --- a/dlls/comctl32/rebar.c
 +++ b/dlls/comctl32/rebar.c
 @@ -1576,8 +1576,6 @@ REBAR_SizeToHeight(REBAR_INFO *infoPtr, int height)
             iRow++;
         }
     }
 -    else
 -        extra -= REBAR_SizeChildrenToHeight(infoPtr, first_visible(infoPtr), 
 infoPtr-uNumBands, extra / infoPtr-uNumRows, fChanged);

IIUC, this should not remove the |REBAR_SizeChildrenToHeight| call,
only the |extra -=| bit as |REBAR_SizeChildrenToHeight| is updating
the |infoPtr| output parameter.

- Reece

Re: comctl32: Remove dead increments (clang)

2011-07-26 Thread Marcus Meissner 
On Tue, Jul 26, 2011 at 09:15:57PM +0200, André Hentschel wrote:
 ---
  dlls/comctl32/propsheet.c |1 -
  dlls/comctl32/rebar.c |2 --
  2 files changed, 0 insertions(+), 3 deletions(-)
 
 diff --git a/dlls/comctl32/propsheet.c b/dlls/comctl32/propsheet.c
 index f711399..3dd0713 100644
 --- a/dlls/comctl32/propsheet.c
 +++ b/dlls/comctl32/propsheet.c
 @@ -543,7 +543,6 @@ static BOOL PROPSHEET_CollectPageInfo(LPCPROPSHEETPAGEW 
 lppsp,
/* Extract the caption */
psInfo-proppage[index].pszText = p;
TRACE(Tab %d %s\n,index,debugstr_w( p ));
 -  p += lstrlenW( p ) + 1;
  
if (dwFlags  PSP_USETITLE)
{
 diff --git a/dlls/comctl32/rebar.c b/dlls/comctl32/rebar.c
 index 99bde77..8d4e6f3 100644
 --- a/dlls/comctl32/rebar.c
 +++ b/dlls/comctl32/rebar.c
 @@ -1576,8 +1576,6 @@ REBAR_SizeToHeight(REBAR_INFO *infoPtr, int height)
  iRow++;
  }
  }
 -else
 -extra -= REBAR_SizeChildrenToHeight(infoPtr, first_visible(infoPtr), 
 infoPtr-uNumBands, extra / infoPtr-uNumRows, fChanged);
  
  if (fChanged)
  REBAR_Layout(infoPtr);

REBAR_SizeChildrenToHeight might set fChanged here, or?

Ciao, Marcus