Re: comctl32: listview should accept both unicode and ansi notifications.
On 02/18/2010 01:46 PM, Dmitry Timoshkov wrote: Listview receives notifications not only from built-in header control, but also from custom or subclassed application controls, there is no need to assert(0) on application input, printing a FIXME is the maximum we can do on an unknown input. Added test case passes under XP, but listview in Wine intentionally crashes itself on an absolutely valid input. --- dlls/comctl32/listview.c | 18 +++--- dlls/comctl32/tests/listview.c | 40 2 files changed, 55 insertions(+), 3 deletions(-) Hi Dmitry, This one has introduced a test failure on some XP and W2K3 boxes. It looks like it's only on W2K3 without a servicepack and XP SP2+. So broken() seems to be appropriate, not? Could you have a look? -- Cheers, Paul.
Re: comctl32: listview should accept both unicode and ansi notifications.
On 2/18/2010 15:46, Dmitry Timoshkov wrote: Listview receives notifications not only from built-in header control, but also from custom or subclassed application controls, there is no need to assert(0) on application input, printing a FIXME is the maximum we can do on an unknown input. The question actually is how does it react on it. Your test only check for return value and most likely doesn't use this conversion path (I'm not sure). The this is so strict probably was that we set notification format when header query for it, and we expect proper codes after that. Anyway change looks a bit confusing cause logically we shouldn't convert to ansi if we have ansi already. Added test case passes under XP, but listview in Wine intentionally crashes itself on an absolutely valid input. Yes, FIXME is ok here.
