Re: d3dx9: Implement D3DXSHEvalConeLight

[Matteo Bruni]

Hi,

in addition to what I already told you in #winehackers (that is,
please rename the test struct field red_in to red_out and red_out to
red_expected, or something like that), you should take the chance to
do some more cleanup. That means e.g. use "const" instead of "CONST"
as Rico already suggested and fix the indentation of the last comment
you're adding.

There are a few other things I don't really like but it's about code
style and my personal preferences, so you are free to ignore them.

I'd write the test structure declaration as:

struct
{
float *red_out, *green_out, *blue_out;
const float *red_expected, *green_expected, *blue_expected;
float radius, red_offset, green_offset, blue_offset;
}
test[] =
{
{rout, gout, bout, table, &table[72], &table[144], 0.5f, 1.01f,
1.02f, 1.03f},
...
(I'm sure Gmail will wrap and make this piece of code unreadable, but well...)

In general I'd also avoid using caps in variable names (e.g.
r_intensity instead of Rintensity).

Re: d3dx9: Implement D3DXSHEvalConeLight (resend)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23862

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: d3dx9: Implement D3DXSHEvalConeLight [try 4]

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23666

Your paranoid android.


=== WXPPROSP3 (32 bit math) ===
math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, 
received 137.556320

=== W2K3R2SESP2 (32 bit math) ===
math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, 
received 137.556320

=== WVISTAADM (32 bit math) ===
math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, 
received 137.556320

=== W2K8SE (32 bit math) ===
math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, 
received 137.556320
math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, 
received 137.556320
math.c: