Re: gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
On Fri, Jun 18, 2010 at 12:18 PM, Jerome Leclanche adys...@gmail.com wrote: On Fri, Jun 18, 2010 at 10:57 AM, Damjan Jovanovic damjan@gmail.com wrote: The icons look cute and I like the version numbers, but you can't thumbnail all Windows files outside Wine - for example .lnk files internally specify a C:\path\to\file.ico style path to the icon which then requires Wine's drive settings to resolve (or worse, use the file extension's default icon from the Windows registry). Can't this be fixed with winepath magic? The .lnk file is opened and the icon path and index are extracted by an IShellLink[A/W]_Xxx() function. First that icon path is opened as an .exe or .dll and the given index in its resource table is searched for the best looking icon. Failing that, the icon path is opened as a .ico file and the best looking icon is searched there instead. Failing that, the extension of the icon path (eg. .hlp) is looked up as a subkey of HKEY_CLASSES_ROOT, and the DefaultIcon entry is used as before (first try .exe, then .ico). Failing that, the default icon for the open handler of that extension (eg. winhlp32.exe for .hlp) is extracted and used. Failing even that, the wineglass icon is used. Little of this can be done outside Wine for .lnk, which will be going on the desktop instead of .desktop files soon enough (http://bugs.winehq.org/show_bug.cgi?id=3548 comment 27 and later). Damjan Jovanovic
Re: gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
On 06/18/2010 03:18 AM, Jerome Leclanche wrote: On Fri, Jun 18, 2010 at 10:57 AM, Damjan Jovanovic damjan@gmail.com wrote: The icons look cute and I like the version numbers, but you can't thumbnail all Windows files outside Wine - for example .lnk files internally specify a C:\path\to\file.ico style path to the icon which then requires Wine's drive settings to resolve (or worse, use the file extension's default icon from the Windows registry). Can't this be fixed with winepath magic? What was the plan for .lnk files anyway? Last I heard we were discussing ways to hide them from the interface entirely, so giving them an icon wouldn't really matter. I am planning to add thumbnailing for .exe files to Wine's winemenubuilder when my .lnk thumbnailing patch gets accepted - probably post Wine 1.2. In addition Windows has its own thumbnailing mechanism that applications can register with, which Wine could integrate into freedesktop.org as well at some stage. Your new wineglass icon looks good. Could you please send a patch to replace programs/winemenubuilder/wine.xpm with your one? Also, with the recent patches, winemenubuilder should hardly ever generate the wineglass for menus any more. Shouldn't that icon just be the normal new straight-up wineglass icon that we use elsewhere? ie: http://www.airwebreathe.org.uk/wine-icon/oic_winlogo-48-32.png Icons look good indeed. Is there a switch I can flick to turn off the version numbers though? No, not at the moment. Even more worrisome is that there's nowhere to see the version information other than by squinting at the icon itself -- right click-properties would be a good place for that, but that's another task. Thanks, Scott Ritchie
Re: gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
On Fri, Jun 18, 2010 at 2:55 AM, Scott Ritchie sc...@open-vote.org wrote: Screenshot/blog here: http://yokozar.org/blog/archives/225 A bug was fixed recently in Gnome that allows thumbnailers to not be 96x96 pixels. Combine this with a standard Wine icon, icoutils for extracting an exe/dll's embedded icon, and a bit of magic and you can get icons like those above. The version numbers come from the .exe metadata. I think it's really slick, and will try and have it installed by default with Wine 1.2. At the moment it exists as thumbnailer code for Gnome, which means other desktops won't benefit, however provided they can be told to run a script to generate an icon it should be fairly easy to port. Code is available in the gnome-exe-thumbnailer source package here: https://edge.launchpad.net/~ubuntu-wine/+archive/ppa Please note that this is an updated version of the proof of concept gnome-exe-thumbnailer package I put in Lucid (which is ugly and uses the overly large 96x96 icons, and is thus not default and has so far gone unnoticed). Thanks, Scott Ritchie The icons look cute and I like the version numbers, but you can't thumbnail all Windows files outside Wine - for example .lnk files internally specify a C:\path\to\file.ico style path to the icon which then requires Wine's drive settings to resolve (or worse, use the file extension's default icon from the Windows registry). I am planning to add thumbnailing for .exe files to Wine's winemenubuilder when my .lnk thumbnailing patch gets accepted - probably post Wine 1.2. In addition Windows has its own thumbnailing mechanism that applications can register with, which Wine could integrate into freedesktop.org as well at some stage. Your new wineglass icon looks good. Could you please send a patch to replace programs/winemenubuilder/wine.xpm with your one? Also, with the recent patches, winemenubuilder should hardly ever generate the wineglass for menus any more. Thank you Damjan Jovanovic
Re: gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
On Fri, Jun 18, 2010 at 10:57 AM, Damjan Jovanovic damjan@gmail.com wrote: The icons look cute and I like the version numbers, but you can't thumbnail all Windows files outside Wine - for example .lnk files internally specify a C:\path\to\file.ico style path to the icon which then requires Wine's drive settings to resolve (or worse, use the file extension's default icon from the Windows registry). Can't this be fixed with winepath magic? I am planning to add thumbnailing for .exe files to Wine's winemenubuilder when my .lnk thumbnailing patch gets accepted - probably post Wine 1.2. In addition Windows has its own thumbnailing mechanism that applications can register with, which Wine could integrate into freedesktop.org as well at some stage. Your new wineglass icon looks good. Could you please send a patch to replace programs/winemenubuilder/wine.xpm with your one? Also, with the recent patches, winemenubuilder should hardly ever generate the wineglass for menus any more. Thank you Damjan Jovanovic Icons look good indeed. Is there a switch I can flick to turn off the version numbers though? -- J. Leclanche
gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
Screenshot/blog here: http://yokozar.org/blog/archives/225 A bug was fixed recently in Gnome that allows thumbnailers to not be 96x96 pixels. Combine this with a standard Wine icon, icoutils for extracting an exe/dll's embedded icon, and a bit of magic and you can get icons like those above. The version numbers come from the .exe metadata. I think it's really slick, and will try and have it installed by default with Wine 1.2. At the moment it exists as thumbnailer code for Gnome, which means other desktops won't benefit, however provided they can be told to run a script to generate an icon it should be fairly easy to port. Code is available in the gnome-exe-thumbnailer source package here: https://edge.launchpad.net/~ubuntu-wine/+archive/ppa Please note that this is an updated version of the proof of concept gnome-exe-thumbnailer package I put in Lucid (which is ugly and uses the overly large 96x96 icons, and is thus not default and has so far gone unnoticed). Thanks, Scott Ritchie
