Re: hhctrl.ocx - null pointer bug

2010-06-19 Thread Jaroslav Šmíd 
Crash happens in 7-zip when opening context help from help menu

On Sat, Jun 19, 2010 at 7:05 AM, Dmitry Timoshkov
dmi...@codeweavers.com wrote:
 Jaroslav Šmíd jardas...@gmail.com wrote:

 Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html
 sent by Dmitry Timoshkov contains bug resulting in wine crash due to
 possible null pointer dereference. Please, see bug report at
 http://bugs.winehq.org/show_bug.cgi?id=23247 for more information.

 You need to fix dlls/hhctrl.ocx/chm.c,LoadWinTypeFromCHM() to fill defaults
 in all cases instead.

 Is that a real or just possible crash? From your description and the bug 
 report
 it sounds like a theoretical issue.

 --
 Dmitry.




-- 
Jaroslav Šmíd

Re: hhctrl.ocx - null pointer bug

2010-06-18 Thread Juan Lang 
Hi Jaroslav,

-if (!*caption) caption = info-pCHMInfo-defTitle;
+if (!caption) caption = info-pCHMInfo-defTitle;

I suspect a better fix would be:
+if (!caption || !*caption) caption = info-pCHMInfo-defTitle;

That is, either a NULL caption or an empty one results in
info-pCHMInfo-defTitle getting used.
--Juan

Re: hhctrl.ocx - null pointer bug

2010-06-18 Thread Jaroslav Šmíd 
Perhaps. I don't mind as long as it doesn't crash :-)


-- 
Jaroslav Šmíd

Re: hhctrl.ocx - null pointer bug

2010-06-18 Thread Dmitry Timoshkov 
Jaroslav Šmíd jardas...@gmail.com wrote:

 Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html
 sent by Dmitry Timoshkov contains bug resulting in wine crash due to
 possible null pointer dereference. Please, see bug report at
 http://bugs.winehq.org/show_bug.cgi?id=23247 for more information.

You need to fix dlls/hhctrl.ocx/chm.c,LoadWinTypeFromCHM() to fill defaults
in all cases instead.

Is that a real or just possible crash? From your description and the bug 
report
it sounds like a theoretical issue.

-- 
Dmitry.