Re: hlink/hlink_main.c : Remove an unneeded assignment.

[Amine Khaldi]

Hi Amine, 

Hi Jacek,




  r = register_clsid(CLSID_StdHlink);
  if (SUCCEEDED(r))
 -r = register_clsid(CLSID_StdHlinkBrowseContext);
 +register_clsid(CLSID_StdHlinkBrowseContext);

  return S_OK;



In this case the correct fix is to return r. Please be more careful 
then doing janitorial work. There are more places in your patches that 
seem questionable. You should make sure that we want to ignore an 
error instead of handling it (and usually we don't) before deleting 
such assignments. Otherwise it's just hiding bugs.


Hmm.. I missed this point, sorry.

Thanks,
Amine.

Re: hlink/hlink_main.c : Remove an unneeded assignment.

[Jacek Caban]

Hi Amine,


  r = register_clsid(CLSID_StdHlink);
  if (SUCCEEDED(r))
 -r = register_clsid(CLSID_StdHlinkBrowseContext);
 +register_clsid(CLSID_StdHlinkBrowseContext);

  return S_OK;



In this case the correct fix is to return r. Please be more careful then doing 
janitorial work. There are more places in your patches that seem questionable. 
You should make sure that we want to ignore an error instead of handling it 
(and usually we don't) before deleting such assignments. Otherwise it's just 
hiding bugs.


Thanks,
Jacek