Re: kernel32: Enhance EndUpdateResource
Andrey Turkin andrey.tur...@gmail.com writes: Fixes bugs 12017 and 22812 --- dlls/kernel32/resource.c | 113 +++ dlls/kernel32/tests/resource.c | 307 +++- 2 files changed, 326 insertions(+), 94 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so package.c touch package.ok package.c:7660: Test failed: Expected , got Z:\home\julliard\wine\wine\dlls\msi\tests\FileName9.dll package.c:8289: Test failed: Expected , got Z:\home\julliard\wine\wine\dlls\msi\tests\FileName4.dll package.c:8626: Test failed: Expected , got Z:\home\julliard\wine\wine\dlls\msi\tests\FileName3.dll package.c:8905: Test failed: Expected Z:\home\julliard\wine\wine\dlls\msi\tests\FileName3.dll, got make: *** [package.ok] Error 4 -- Alexandre Julliard julli...@winehq.org
Re: kernel32: Enhance EndUpdateResource
On Sunday 18 July 2010 00:26:36 Henri Verbeet wrote:
On 17 July 2010 09:06, Andrey Turkin andrey.tur...@gmail.com wrote:
+if (nt-OptionalHeader.FileAlignment = 0)
I can't comment much on the changes themselves, but FileAlignment is
unsigned, so can't be 0.
Original function has this check just before that added line:
if (nt-OptionalHeader.SectionAlignment = 0)
{
ERR(invalid section alignment %04x\n,
nt-OptionalHeader.SectionAlignment);
goto done;
}
So I've added something similar. The point here is to check alignments are
positive; = works just as well as !=, and is describes not positive
condition better than !=.
Re: kernel32: Enhance EndUpdateResource
On 17 July 2010 09:06, Andrey Turkin andrey.tur...@gmail.com wrote: +if (nt-OptionalHeader.FileAlignment = 0) I can't comment much on the changes themselves, but FileAlignment is unsigned, so can't be 0.
Re: kernel32: Enhance EndUpdateResource
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3105 Your paranoid android. === WNT4WSSP6 (32 bit resource) === No test summary line found
