Re: msi: Fix handling of the no-op identifier in the Directory table [resend]

2006-06-20 Thread Alexandre Julliard
Saulius Krasuckas <[EMAIL PROTECTED]> writes:

> Alexandre, maybe we should know what CGLAGS are you using so we can use 
> them too and detect such compiler warnings in future?  Would you reveal 
> them, please? :)

I don't use special flags, just a standard configure. You may need a
more recent gcc to see all the warnings.

-- 
Alexandre Julliard
[EMAIL PROTECTED]




Re: msi: Fix handling of the no-op identifier in the Directory table [resend]

2006-06-20 Thread Saulius Krasuckas
* On Tue, 20 Jun 2006, Alexandre Julliard wrote:
> * "James Hawkins" <[EMAIL PROTECTED]> writes:
> > 
> > Is there anything wrong with this patch?
> 
> You are assigning a const string to a non-const variable, that causes 
> warnings.

Alexandre, maybe we should know what CGLAGS are you using so we can use 
them too and detect such compiler warnings in future?  Would you reveal 
them, please? :)




Re: msi: Fix handling of the no-op identifier in the Directory table [resend]

2006-06-20 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes:

> Is there anything wrong with this patch?
>
> Changelog:
> * Fix handling of the no-op identifier in the Directory table.

You are assigning a const string to a non-const variable, that causes
warnings.

-- 
Alexandre Julliard
[EMAIL PROTECTED]