Help for my first patch
Hi, I'm using Wine with xUbuntu and you may be know, the menu and toolbar of xfce are often visible. So I've looked at xfce forum and saw that wine doesn't inform xfce that window is fullscreen... At http://standards.freedesktop.org/wm-spec/wm-spec-latest.html, I've found a _NET_WM_STATE_FULLSCREEN flag. After digging in wine source, I've found in dlls/winex11.drv/window.c the function create_whole_window (I think that this function is called when a game want a resolution which isn't supported by X, wine used this function to fake fullscreen ?, correct me I'm wrong) If in set_wm_hints, I force the window_type to _NET_WM_STATE_FULLSCREEN, toolbar and menu of xfce disappears. (tested with Wizardry 8) My problem is how detect in this function that I came from create_whole_window and not from others functions ? Do I have to test size of window to current resolution and use this flag ? Or call XChangeProperty in create_whole_window ? Thanks in advance, Michael
Re: Help for my first patch
Hi, Sorry to disappoint you but I have a feeling that this is most likely a bug in Xfce instead of Wine. Our window management code might use some legacy mechanisms here and there but it works on all window managers (except for this Xfce issue). A few years ago we had similar issues with Metacity and they fixed it in there. I think you can find info about it in the wine-devel archives. I don't know all the tech details of winex11.drv. Likely someone more qualified like Alexandre can tell you more. Regards, Roderick Hi, I'm using Wine with xUbuntu and you may be know, the menu and toolbar of xfce are often visible. So I've looked at xfce forum and saw that wine doesn't inform xfce that window is fullscreen... At http://standards.freedesktop.org/wm-spec/wm-spec-latest.html, I've found a _NET_WM_STATE_FULLSCREEN flag. After digging in wine source, I've found in dlls/winex11.drv/window.c the function create_whole_window (I think that this function is called when a game want a resolution which isn't supported by X, wine used this function to fake fullscreen ?, correct me I'm wrong) If in set_wm_hints, I force the window_type to _NET_WM_STATE_FULLSCREEN, toolbar and menu of xfce disappears. (tested with Wizardry 8) My problem is how detect in this function that I came from create_whole_window and not from others functions ? Do I have to test size of window to current resolution and use this flag ? Or call XChangeProperty in create_whole_window ? Thanks in advance, Michael -- GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! Jetzt dabei sein: http://www.shortview.de/[EMAIL PROTECTED]
Trying to submit my first patch
So I tried to submit a patch (to the patch mailing list) a few days ago and got no response (or acceptance), so I'm guessing I need to do something different. It is just a few simple stubs for functions needed to get RO2 (a game) running. The original email is attached. If anyone could tell me what I did wrong it would be appreciated. I'm guessing either because (a) I actually changed the Changelog file and included that in the patch instead of putting it in the email body or (b) nobody is interested in just stubs and I should work on coding them up more (even though it isn't necessary to get the game running.) -- Chris Wulff ---BeginMessage--- 0001-Added-stubs-for-KfAcquireSpinLock-KfLowerIrql-KfRa.patch Description: application/mbox 0002-Added-a-stub-for-FindVolumeMountPointClose.patch Description: application/mbox ---End Message---
Re: Trying to submit my first patch
Hi Chris, So I tried to submit a patch (to the patch mailing list) a few days ago and got no response (or acceptance), so I'm guessing I need to do something different. It is just a few simple stubs for functions needed to get RO2 (a game) running. The original email is attached. If anyone could tell me what I did wrong it would be appreciated. Two small things: 1. You're right, you don't need to include changes to the ChangeLog, they're generated from git commits anyway. 2. Please include your name in your emails. This one does (thanks) but the patch email should as well. Aside from that, I'm guessing the hal patch just looks ugly due to the wacky calling convention and assembly, so you might wait for feedback from Alexandre on that. If you don't hear anything, ask again in a couple days ;) Thanks for contributing, --Juan
Re: Trying to submit my first patch
Juan, Thanks for the quick response. The fastcall assembly I actually copied from another DLL (I think it was in ntoskrnl.exe or ntdll.dll.) There should probably be a standard place for the fastcall macros instead, but I didn't see one off hand. If you happen to know a good place to put them I can always clean that up and submit a new patch. It is too bad that the fastcall conventions aren't standardized between the various compilers so we have to force the windows ones though. -- Chris Wulff - Original Message - From: Juan Lang [EMAIL PROTECTED] Date: Monday, October 29, 2007 7:18 pm Subject: Re: Trying to submit my first patch To: [EMAIL PROTECTED] [EMAIL PROTECTED] Cc: wine-devel@winehq.org Hi Chris, So I tried to submit a patch (to the patch mailing list) a few days ago and got no response (or acceptance), so I'm guessing I need to do something different. It is just a few simple stubs for functions needed to get RO2 (a game) running. The original email is attached. If anyone could tell me what I did wrong it would be appreciated. Two small things: 1. You're right, you don't need to include changes to the ChangeLog, they're generated from git commits anyway. 2. Please include your name in your emails. This one does (thanks) but the patch email should as well. Aside from that, I'm guessing the hal patch just looks ugly due to the wacky calling convention and assembly, so you might wait for feedback from Alexandre on that. If you don't hear anything, ask again in a couple days ;) Thanks for contributing, --Juan
Re: my first patch
This looks good, I am not an expert in that area.
Send this patch to [EMAIL PROTECTED]
Cheers,
VJ
On 10/26/07, viny [EMAIL PROTECTED] wrote:
Can someone tell me if this patch is correct for submitting to wine-patches.
I have generated this patch with git format-patch -o out origin
(related bug : http://bugs.winehq.org/show_bug.cgi?id=9805)
From c5eab13b67e6f24b3518dd77840f260dc101520e Mon Sep 17 00:00:00 2001
From: Vincent Hardy [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 13:37:39 +0200
Subject: [PATCH] Add TypeLib version for W2K, WXP, and Vista
---
dlls/oleaut32/typelib16.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/dlls/oleaut32/typelib16.c b/dlls/oleaut32/typelib16.c
index a010f7d..31bbf93 100644
--- a/dlls/oleaut32/typelib16.c
+++ b/dlls/oleaut32/typelib16.c
@@ -153,6 +153,9 @@ HRESULT WINAPI LoadTypeLib16(
*| OLE 2.1 NT 1993-95 ?? ???
*| OLE 2.3.1 W95 23 700
*| OLE2 4.0 NT4SP6 1993-98 40 4277
+ *| OLE 2.1 W2K2000 10 3029
+ *| OLE 2.1 WXP2002 10 3029
+ *| OLE 2.1 Vista 2007 10 3029
*/
DWORD WINAPI OaBuildVersion16(void)
{
@@ -171,6 +174,12 @@ DWORD WINAPI OaBuildVersion16(void)
return MAKELONG(3024, 10); /* W98 SE */
case 0x0004: /* NT4 */
return MAKELONG(4277, 40); /* NT4 SP6 */
+case 0x0005: /* W2K */
+ return MAKELONG(3029, 10); /* W2K SP4 */
+case 0x0105: /* WXP */
+ return MAKELONG(3029, 10); /* WXP SP2 */
+case 0x0006: /* Vista */
+ return MAKELONG(3029, 10); /* Vista */
default:
FIXME(Version value not known yet. Please investigate it!\n);
return 0;
--
1.5.2.5
my first patch
Can someone tell me if this patch is correct for submitting to wine-patches.
I have generated this patch with git format-patch -o out origin
(related bug : http://bugs.winehq.org/show_bug.cgi?id=9805)
From c5eab13b67e6f24b3518dd77840f260dc101520e Mon Sep 17 00:00:00 2001
From: Vincent Hardy [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 13:37:39 +0200
Subject: [PATCH] Add TypeLib version for W2K, WXP, and Vista
---
dlls/oleaut32/typelib16.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/dlls/oleaut32/typelib16.c b/dlls/oleaut32/typelib16.c
index a010f7d..31bbf93 100644
--- a/dlls/oleaut32/typelib16.c
+++ b/dlls/oleaut32/typelib16.c
@@ -153,6 +153,9 @@ HRESULT WINAPI LoadTypeLib16(
*| OLE 2.1 NT 1993-95 ?? ???
*| OLE 2.3.1 W95 23 700
*| OLE2 4.0 NT4SP6 1993-98 40 4277
+ *| OLE 2.1 W2K2000 10 3029
+ *| OLE 2.1 WXP2002 10 3029
+ *| OLE 2.1 Vista 2007 10 3029
*/
DWORD WINAPI OaBuildVersion16(void)
{
@@ -171,6 +174,12 @@ DWORD WINAPI OaBuildVersion16(void)
return MAKELONG(3024, 10); /* W98 SE */
case 0x0004: /* NT4 */
return MAKELONG(4277, 40); /* NT4 SP6 */
+case 0x0005: /* W2K */
+ return MAKELONG(3029, 10); /* W2K SP4 */
+case 0x0105: /* WXP */
+ return MAKELONG(3029, 10); /* WXP SP2 */
+case 0x0006: /* Vista */
+ return MAKELONG(3029, 10); /* Vista */
default:
FIXME(Version value not known yet. Please investigate it!\n);
return 0;
--
1.5.2.5
Re: my first patch
Hi Vincent, viny schreef: Can someone tell me if this patch is correct for submitting to wine-patches. I have generated this patch with git format-patch -o out origin Anything created by git-diff or git-format patch will automatically be inthe proper format. Cheers, Maarten.
