my patch was wrong at dlls/kernel32/computernames.c
From if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 17; i++ ) To if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 16; i++ ) and the original version was wrong,too. It counts the NULL of the end.
Re: my patch was wrong at dlls/kernel32/computernames.c
On Thu, Aug 29, 2013 at 11:31:06PM +0900, matyapiro31 wrote: From if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 17; i++ ) To if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 16; i++ ) and the original version was wrong,too. It counts the NULL of the end. Thats why you should use sizeof() or strlen() ... and not hardcoded magic values. CIao, Marcus