Re: programs/winetest: bump file size limit to 1.75 MB (1/2)
Hello Austin,
Austin English wrote:
> There were no test results on winehq today. Seems everyone's exceeding
> 1.5. Guess some new tests today have a lot of output...
wouldn't it make more sense to have a global variable 'max_filesize'
instead of duplicating the magic constants all over the place?
> diff --git a/programs/winetest/send.c b/programs/winetest/send.c
> index 11c9f33..9fc4b81 100644
> --- a/programs/winetest/send.c
> +++ b/programs/winetest/send.c
> @@ -155,11 +155,11 @@ send_file_direct (const char *name)
> goto abort1;
> }
> filesize = GetFileSize( file, NULL );
> -if (filesize > 1.5*1024*1024) {
> +if (filesize > 1.75*1024*1024) {
> report (R_WARNING,
> -"File too big (%.1f MB > 1.5 MB); submitting partial
> report.",
> +"File too big (%.1f MB > 1.75 MB); submitting partial
> report.",
> filesize/1024.0/1024);
> -filesize = (DWORD) 1.5*1024*1024;
> +filesize = (DWORD) 1.75*1024*1024;
> }
>
> report (R_STATUS, "Sending header");
> @@ -298,11 +298,11 @@ send_file_wininet (const char *name)
> }
>
> filesize = GetFileSize( file, NULL );
> -if (filesize > 1.5*1024*1024) {
> +if (filesize > 1.75*1024*1024) {
> report (R_WARNING,
> -"File too big (%.1f MB > 1.5 MB); submitting partial
> report.",
> +"File too big (%.1f MB > 1.75 MB); submitting partial
> report.",
> filesize/1024.0/1024);
> -filesize = 1.5*1024*1024;
> +filesize = 1.75*1024*1024;
> }
>
> report (R_STATUS, "Opening HTTP connection to " SERVER_NAME);
bye
michael
Re: programs/winetest: bump file size limit to 1.75 MB (1/2)
On Tue, Jul 27, 2010 at 2:01 AM, Paul Vriens wrote: > On 07/27/2010 03:48 AM, Austin English wrote: >> >> There were no test results on winehq today. Seems everyone's exceeding >> 1.5. Guess some new tests today have a lot of output... >> > > I do see output for July 26th or am I missing something? http://test.winehq.org/data/20f51c29a99299384e840e148f02aae66bfb45be/ I don't see any for wine. All of my test setups failed when sending with the error of a too large data file. > We could use a volunteer to implement compression for the winetest reports. That of course would be better... -- -Austin
Re: programs/winetest: bump file size limit to 1.75 MB (1/2)
Paul Vriens writes: > On 07/27/2010 03:48 AM, Austin English wrote: >> There were no test results on winehq today. Seems everyone's exceeding >> 1.5. Guess some new tests today have a lot of output... >> > > I do see output for July 26th or am I missing something? > > We could use a volunteer to implement compression for the winetest reports. That shouldn't be necessary. Just fix the offending test (urlmon:uri in this case). -- Alexandre Julliard julli...@winehq.org
Re: programs/winetest: bump file size limit to 1.75 MB (1/2)
On 07/27/2010 03:48 AM, Austin English wrote: There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output... I do see output for July 26th or am I missing something? We could use a volunteer to implement compression for the winetest reports. -- Cheers, Paul.
