Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
On Do, 2008-06-26 at 22:58 -0700, Maarten Lankhorst wrote: there are still some things I need to figure out with avi. Is avifil32.dll usable for that? Does Windows reuse avifil32.dll or did MS again lots of code duplication? The current Problem in Wine is the correct importlib: avicap32 + avifil32 + msvfw32 = vfw32 ( http://bugs.winehq.org/show_bug.cgi?id=14085 ) -- By by ... Detlef
Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
Hello Detlef, 2008/6/28 Detlef Riekenberg [EMAIL PROTECTED]: On Do, 2008-06-26 at 22:58 -0700, Maarten Lankhorst wrote: there are still some things I need to figure out with avi. Is avifil32.dll usable for that? Does Windows reuse avifil32.dll or did MS again lots of code duplication? It's slightly impossible to re-use the existing code as it expects a file based backend. The avi filter in wine should also be able to use a http, or any other backend. The issues are more in handling of certain operations like seeking and stop/start/stop, which I haven't fully handled well yet. Cheers, Maarten.
Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
Maarten Lankhorst [EMAIL PROTECTED] writes: +FIXME(Waiting for %u to terminate\n, x); +/* Make the thread return first */ +SetEvent(stream-packet_queued); +if (WaitForSingleObject(stream-thread, 1) == WAIT_TIMEOUT) +exit(1); Don't use exit(). If you absolutely need to kill the whole process you should use ExitProcess, and you have to print an error so that users know what happened. But I doubt you need such a drastic action here. -- Alexandre Julliard [EMAIL PROTECTED]
Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
On Mi, 2008-06-25 at 21:34 -0700, Maarten Lankhorst wrote: Because of the magnitude of the change I cannot split this patc hup, my apologies for this. Without any view at your code, the sentense above is wrong by design. A Test is always independant from the implementation, and what permit a seperate patch for test_threads() to split the tests? -- By by ... Detlef
Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
Hi Detlef, 2008/6/26 Detlef Riekenberg [EMAIL PROTECTED]: On Mi, 2008-06-25 at 21:34 -0700, Maarten Lankhorst wrote: Because of the magnitude of the change I cannot split this patc hup, my apologies for this. Without any view at your code, the sentense above is wrong by design. A Test is always independant from the implementation, and what permit a seperate patch for test_threads() to split the tests? Oops, you're right, I missed that. :-) I'll split it up later, there are still some things I need to figure out with avi. Cheers, Maarten.
